Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle assignment ops #10728

Open
wants to merge 2 commits into
base: 2.13.x
Choose a base branch
from

Conversation

som-snytt
Copy link
Contributor

REPL decides rendering from untyped tree, so it doesn't see expansion of assignments.

This fix just handles "assignment operators" and hopes for the best.

Fixes scala/bug#12894

@scala-jenkins scala-jenkins added this to the 2.13.15 milestone Mar 25, 2024
@som-snytt
Copy link
Contributor Author

som-snytt commented Mar 26, 2024

Added tweak from my previous branch issue/12894-op= which is a cooler name, I should have kept it.

Does not yet update what to display on mutation. Was the original reason to hesitate to display the mutated value that printing would force too much? For example, var it = Iterator.continually(42).

If I update a mutable map, do I want to see the whole map or just what I updated? That "diff" view is helpful for m += computed.

@som-snytt som-snytt marked this pull request as ready for review March 31, 2024 21:23
@lrytz lrytz requested a review from SethTisue April 3, 2024 09:52
@SethTisue SethTisue self-assigned this Apr 3, 2024
@SethTisue
Copy link
Member

(I'll take a look after 2.13.14 is out.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants