Invalidate sources that depends on @inline methods
#10633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(This looks attractive — and thank you! — but let's get 2.13.13 out the door first.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes sbt/sbt#4125, sbt/zinc#537.
Issue
When
@inlinemethod implementation changes, the public API of@inlinemethod does not change, hence Zinc does not invalidate sources that depends on@inlinemethod.Solution
The behaviour of
@inlinemethod is similar to macro methods. Hence, we can mark@inlinemethod as macro and reuse existing Zinc invalidation logic for macro invalidation.Validating the fix
Scripted test is added to Zinc side (sbt/zinc#1310). The test passed.
TODOs
@inline. To handle that case, we need to follow -opt:l:inline breaks incremental compilation sbt/zinc#537 (comment) and drop call-site@inlineat compiler side.@inlineannotation, compiler may still sometimes inline a method. The compiler keep a log of inlined methods, so in a follow up PR, we can utilize that information instead of directly checking@inlineannotation.