Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore a bit of spec language that went missing #10225

Merged
merged 1 commit into from Nov 23, 2022

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Nov 23, 2022

This came up during some Scala 3 work. "I could have sworn the spec said something about this," I thought, and I was right — it did, before it didn't again.

A little digging revealed that the language in question was added by Adriaan in #7680 but then accidentally got removed in 2020 by #7432.

I looked through other spec commits in that date span and didn't find anything else that went missing

@scala-jenkins scala-jenkins added this to the 2.13.11 milestone Nov 23, 2022
@SethTisue SethTisue added the documentation No code change. Only documentation label Nov 23, 2022
@som-snytt
Copy link
Contributor

What a find. If I ever need to find a bit of hay in a stack of needles, etc.

the language in question was added by Adriaan in scala#7680
but then accidentally got removed in 2020 by scala#7432

I looked through other spec commits in that date span and
didn't find anything else that went missing
Copy link
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice..!

@lrytz lrytz merged commit a3dc079 into scala:2.13.x Nov 23, 2022
@SethTisue SethTisue deleted the spec-overloading-plus-varargs branch November 23, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation No code change. Only documentation
Projects
None yet
4 participants