Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore -Vprint-args, for echoing arguments provided to compiler #10164

Merged
merged 2 commits into from Sep 30, 2022

Conversation

som-snytt
Copy link
Contributor

@som-snytt som-snytt commented Sep 26, 2022

It was accidentally put back on the info arg list. Insult to injury, its "-" arg was no longer parsed.

Unreverts and improves #10123

Note that this is irrespective of how "command lines" are tokenized, as arg files are no longer tokenized.

Apologies to retronym, who set up the current facility in 2018, which I broke in 2019 (but only on 2.13, which must be why retronym didn't notice).

It was accidentally put back on the info arg list.
Insult to injury, its "-" arg was no longer parsed.
@scala-jenkins scala-jenkins added this to the 2.13.10 milestone Sep 26, 2022
@som-snytt
Copy link
Contributor Author

The default for -Vprint-args is "-", which means that the user setting -Vprint-args - does not show up in the resulting output, ironically. The default should be empty string; feature is triggered by value set by user. Changing it is left to future generations, so that they cannot say that we left nothing for them to do.

@SethTisue SethTisue self-assigned this Sep 29, 2022
@SethTisue SethTisue changed the title Restore -Vprint-args Restore -Vprint-args Sep 30, 2022
@SethTisue SethTisue merged commit 9f3ffcf into scala:2.13.x Sep 30, 2022
@som-snytt som-snytt deleted the dev/814-redux-args-file branch September 30, 2022 02:56
@SethTisue SethTisue added the release-notes worth highlighting in next release notes label Oct 8, 2022
@SethTisue SethTisue changed the title Restore -Vprint-args Restore -Vprint-args, for echoing arguments provided to compiler Oct 8, 2022
@som-snytt som-snytt mentioned this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes worth highlighting in next release notes
Projects
None yet
4 participants