in -Wvalue-discard message, include type of discarded value #10092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
approved these changes
Jul 28, 2022
There was a problem hiding this comment.
Probably you're on your phone on the train, so your line width is about 60 chars.
It's interesting to complain about discarding 42, which not an interesting number. That is, we don't lose information by not consuming a singleton.
Thanks, enhancing the other message didn't occur to me. (Because of my laser focus, of course.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspired by the corresponding change to
-Wnonunit-statementwe asked @som-snytt for on #9893