Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scala3-library to 3.0.2 #557

Merged
merged 4 commits into from Sep 9, 2021

Conversation

scala-steward
Copy link
Contributor

Updates

from 3.0.1 to 3.0.2.
GitHub Release Notes - Version Diff - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (3.0.1).
You might want to review and update them manually.

.circleci/config.yml
.travis.yml
Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang" } ]

labels: library-update, semver-patch, old-version-remains

@ashawley
Copy link
Member

ashawley commented Sep 1, 2021

There was a Mima error:

[error] scala-xml: Failed binary compatibility check against org.scala-lang.modules:scala-xml_3:2.0.1! Found 39 potential problems
[error]  * static method canBuildFrom()scala.collection.BuildFrom in class scala.xml.NodeSeq has a different
[error]    generic signature in current version, where it is ()Lscala/collection/BuildFrom<Lscala/xml/NodeSeq;Lscala/xml/Node;Lscala/xml/NodeSeq;>;
[error]    rather than <missing>. See https://github.com/lightbend/mima#incompatiblesignatureproblem
[error]    filter with: ProblemFilters.exclude[IncompatibleSignatureProblem]("scala.xml.NodeSeq.canBuildFrom")
...
[error] (xml / versionPolicyMimaCheck) java.lang.RuntimeException: Failed binary compatibility check
[error] against org.scala-lang.modules:scala-xml_3:2.0.1! Found 39 potential problems

@ashawley
Copy link
Member

ashawley commented Sep 1, 2021

We could just ignore signature checking for Scala 3 for now.

    mimaReportSignatureProblems := (CrossVersion.partialVersion(scalaVersion.value) match {
      case Some((3, _)) => false
      case _ => true
    }),

@SethTisue
Copy link
Member

what do you think the root cause is?

@ashawley
Copy link
Member

ashawley commented Sep 1, 2021

I'm not sure. Either, Mima has a bug with signature checking in Scala 3, or Scala 3 is actually emitting different byte code for these constructs in the scala-xml library?

@SethTisue
Copy link
Member

bat-signaling @dwijnand

@dwijnand
Copy link
Member

dwijnand commented Sep 2, 2021

This isn't about the method descriptor bytecode, but the method signature bytecode, i.e. the one with Java generics. There was a point in Scala 2 where static methods lost/gained signature on its static forwarders. I think what might have happened is Scala 3's backend picked up that change so now it's manifesting in Scala 3 artefacts too. Or maybe it just updated the 2.13 scala-library it uses, so because scala-xml extends scala-library classes (AbstractSeq) it's manifesting transitively.

@ashawley ashawley changed the title Update scala3-library, ... to 3.0.2 Update scala3-library to 3.0.2 Sep 9, 2021
@ashawley ashawley merged commit 0f7d436 into scala:main Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants