Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SeqSet and SetFromMap implementations #35

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Add SeqSet and SetFromMap implementations #35

wants to merge 7 commits into from

Conversation

NthPortal
Copy link
Contributor

@NthPortal NthPortal commented Nov 2, 2020 •
edited

Resolves #21
Resolves #22

TODO:

  • docs
  • tests
  • tidy up code and remove unnecessary blank lines

@NthPortal
Copy link
Contributor Author

I have decided that I don't think there's a compelling enough use case for the SetFromMapOps classes being public, and having the API public is a large maintenance burden, so I'm going make them private

@NthPortal
fixup! fixup! fixup! fixup! Add SeqSet and SetFromMap implementations
9e391c3 
remove unnecessary implicit `Ordering`
@NthPortal
fixup! fixup! fixup! fixup! fixup! Add SeqSet and SetFromMap implemen…
2ed714d 
…tations

try to retain type information mirroring that of the wrapped map
@NthPortal NthPortal added status:pending This enhancement request lacks consensus on whether or not to include it enhancement New feature or request labels Nov 21, 2020
@NthPortal NthPortal mentioned this pull request Dec 3, 2020
Open
@KisaragiEffective KisaragiEffective mentioned this pull request Jan 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request library:collections status:pending This enhancement request lacks consensus on whether or not to include it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SeqSet Support the creation of Sets from Maps
1 participant
@NthPortal