Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only enable optimizer in CI #187

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mdedetrich
Copy link
Contributor

@mdedetrich mdedetrich commented Feb 6, 2024

From https://docs.scala-lang.org/overviews/compiler-options/optimizer.html#in-brief

Don’t enable the optimizer during development: it breaks incremental compilation, and it makes the compiler slower. Only enable it for testing, on CI, and to build releases.

This PR makes it so that the Scala 2 optimizer is only enabled in CI since it causes issues when used in local development with additional logging to make it clear when its enabled.

Note That there is a presumption in that Scala modules that use this sbt-plugin do their releases in CI rather than a local machine. @SethTisue would be good to check if this is the case, if not then then let me know which Scala modules don't use CI for release and I can look into enabling it (I do think that by now all Scala modules should be creating release artifacts in CI).

@SethTisue SethTisue self-assigned this Feb 6, 2024
@SethTisue SethTisue removed their assignment Feb 14, 2024
@SethTisue
Copy link
Member

Note That there is a presumption in that Scala modules that use this sbt-plugin do their releases in CI rather than a local machine. @SethTisue would be good to check if this is the case

Confirmed, this is the case.

Let's find out what Mr. Optimizer himself, @lrytz, thinks about this PR

@SethTisue SethTisue requested a review from lrytz February 14, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants