Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for -release to make it clear it accepts recent Java versions #3009

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rtyley
Copy link

@rtyley rtyley commented Apr 18, 2024

The old displayed values of 6, 7, 8, 9 are confusing for developers contemplating updating to recent Java versions like 21 - eg :

I was getting an error that -release:21 is not a valid compiler option when I ran the code. Looking at the docs: https://docs.scala-lang.org/overviews/compiler-options/ my understanding is that this is not supported for Java 21.

That's an incorrect understanding from the docs, as newer Java versions definitely are supported by the -release Scala compiler parameter - so it's best to clarify that!

In this case, the developer was getting the error because they were accidentally running with an older Java version (the compiler error could probably be clearer there too).

…rsions

The old displayed values of `6, 7, 8, 9` are confusing for developers contemplating updating to recent Java versions like `21` - eg from https://github.com/guardian/mobile-save-for-later/pull/109/files#r1559390842 :

> I was getting an error that -release:21 is not a valid compiler option when I ran the code. Looking at the docs: https://docs.scala-lang.org/overviews/compiler-options/ my understanding is that this is not supported for Java 21.

That's wrong, as newer Java versions definitely are supported by the `-release` Scala compiler parameter - so it's best to clarify that!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant