Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even more section literally doubles chapters Summary #2345

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

ac2epsilon
Copy link

@ac2epsilon ac2epsilon commented Mar 15, 2022

The former one removed/

Also added 5 misphrasings... too small fixes for their own PR:

  • generic type parameter => type parameter (2x)
  • "Hello?" => "Hi people" (Hello? What?)
  • "Yo! I'm totally breathing" => "Meow. I am breathing too" (Totally breathing? What? And cats not saying Yo! Never.)
  • "Nice way to group methods" => "usual way" "common way" "natural way" (Nice way to group methods? Good God!)
  • As shown therein section of that book... => X (Thank you for the detailed coordinates, but...)

Also, 1 small, but more conceptual note:

  • Some words have been added to the parameterless methods section. Namely, the true reason for the existence of such a double syntax is indicated. And it's not just finding out if there's a side effect. There are more valid reasons.

_overviews/scala3-book/control-structures.md Show resolved Hide resolved
_overviews/scala3-book/control-structures.md Outdated Show resolved Hide resolved
_overviews/scala3-book/methods-most.md Outdated Show resolved Hide resolved
_overviews/scala3-book/methods-most.md Outdated Show resolved Hide resolved
_overviews/scala3-book/methods-most.md Outdated Show resolved Hide resolved
_overviews/scala3-book/methods-most.md Show resolved Hide resolved
_overviews/scala3-book/methods-most.md Show resolved Hide resolved
@bishabosha
Copy link
Member

Hey please could you try to rebase this, since you opened the PR we added code tabs with syntax for both scala 2 and 3

@julienrf julienrf marked this pull request as draft April 25, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants