[1.10.x] Fix declaring Optional inter-project dependency in BSP
#7568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpi2
commented
May 22, 2024
Comment on lines
14
to
+18
| private[sbt] object InternalDependencies { | ||
| def configurations: Def.Initialize[Seq[(ProjectRef, Set[String])]] = Def.setting { | ||
| val allConfigs = Classpaths.allConfigs(configuration.value).map(_.name).toSet | ||
| val configMap = internalConfigurationMap.value | ||
| val config = configMap(configuration.value) | ||
| val allConfigs = Classpaths.allConfigs(config).map(_.name).toSet |
There was a problem hiding this comment.
This is used by BSP and by watch. Which means that modifying a will trigger the watch of ~b/compile which seems correct since a is in the compilation classpath of b.
eed3si9n
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In BSP there is no notion of
OptionalorProvideddependencies. But theb#Compilebuild target should contain a dependency toa#Compilebecause it needs it to compile. (The classphath configuration isCompileInternalwhich extendsOptionalandProvided).To fix this we use the
internalConfigurationMapto compute the internal dependencies of a configuration.@unkarjedy This PR should fix https://youtrack.jetbrains.com/issue/SCL-22476/SBTBSP-build-with-an-optional-inter-project-dependency-results-in-cannot-resolve-symbol-errors