Fix unused nowarn in sbt plugins #6431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkurz
reviewed
Apr 6, 2021
|
|
||
| object SbtPlugin extends AutoPlugin { | ||
| override def requires = ScriptedPlugin | ||
|
|
||
| override lazy val projectSettings: Seq[Setting[_]] = Seq( | ||
| sbtPlugin := true | ||
| sbtPlugin := true, | ||
| Compile / scalacOptions += "-Wconf:cat=unused-nowarn:s" |
There was a problem hiding this comment.
Isn't this too global? Wouldn't this silence also other "unused" warnings?
There was a problem hiding this comment.
This option does only silence the unused @nowarn warnings in the SbtPlugin projects.
@nowarn annotation does not suppress any warnings
It is not a perfect solution because it will silence your own unused @nowarn annotations. But it is very specific to sbt plugins and it is harmless.
A better solution would be to have scala/scala#9491 but it is only available in 2.13.
eed3si9n
reviewed
Apr 6, 2021
adpi2
force-pushed
the
fix-6430
branch
4 times, most recently
from
3da6160
to
6768987
Compare
|
Test added. Also the option is only added if scalaVersion >= 2.12.13 because it was not available in 2.12.12. So the solution in 2.12.12 is to upgrade to 2.12.13 |
eed3si9n
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6430