Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence unused-nowarn in meta-build #6403

Merged
merged 1 commit into from Mar 18, 2021
Merged

Silence unused-nowarn in meta-build #6403

merged 1 commit into from Mar 18, 2021

Conversation

adpi2
Copy link
Member

@adpi2 adpi2 commented Mar 18, 2021

Fixes #6398

It would be better to have scala/scala#9491 in 2.12 but we don't have it yet.

@adpi2
Copy link
Member Author

adpi2 commented Mar 18, 2021

Testing locally:

sbt
[info] [launcher] getting org.scala-sbt sbt 1.5.0-SNAPSHOT  (this may take some time)...
[info] welcome to sbt 1.5.0-SNAPSHOT (Ubuntu Java 11.0.10)
[info] loading global plugins from /home/piquerez/.sbt/1.0/plugins
[info] loading settings for project mima-build from plugins.sbt ...
[info] loading project definition from /home/piquerez/lightbend/mima/project
[info] compiling 1 Scala source to /home/piquerez/lightbend/mima/project/target/scala-2.12/sbt-1.0/classes ...
/home/piquerez/lightbend/mima/build.sbt:32: warning: method in in trait ScopingSetting is deprecated (since 1.5.0): `in` is deprecated; migrate to slash syntax - https://www.scala-sbt.org/1.x/docs/Migrating-from-sbt-013x.html#slash
  skip in publish := true,
       ^
/home/piquerez/lightbend/mima/build.sbt:59: warning: method in in trait ScopingSetting is deprecated (since 1.5.0): `in` is deprecated; migrate to slash syntax - https://www.scala-sbt.org/1.x/docs/Migrating-from-sbt-013x.html#slash
  scriptedDependencies := Def.task(()).dependsOn(publishLocal, publishLocal in core).value,
                                                                            ^
/home/piquerez/lightbend/mima/build.sbt:83: warning: method in in trait ScopingSetting is deprecated (since 1.5.0): `in` is deprecated; migrate to slash syntax - https://www.scala-sbt.org/1.x/docs/Migrating-from-sbt-013x.html#slash
    skip in publish := true,
         ^
[info] loading settings for project root from build.sbt ...
[info] set current project to mima (in build file:/home/piquerez/lightbend/mima/)
[info] sbt server started at local:///home/piquerez/.sbt/1.0/server/b07d754fc19c6e72ee47/sock
[info] started sbt server
sbt:mima>

@adpi2 adpi2 requested a review from eed3si9n March 18, 2021 17:30
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit cc94de9 into sbt:develop Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.5.0-RC1] @nowarn annotation does not suppress any warnings
2 participants