fix(schedule): disallow empty schedule name

sb-im · Jun 25, 2023 · c8eb703 · c8eb703
1 parent 22f070d
commit c8eb703
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/src/i18n/locale/en.js b/src/i18n/locale/en.js
@@ -144,7 +144,8 @@ export default {
       trigger_success: 'Schedule Triggered'
     },
     edit: {
-      new: 'New Schedule'
+      new: 'New Schedule',
+      empty_name: 'Schedule Name cannot be empty'
     }
   },
   air: {

diff --git a/src/i18n/locale/zh.js b/src/i18n/locale/zh.js
@@ -144,7 +144,8 @@ export default {
       trigger_success: '定时任务执行完成'
     },
     edit: {
-      new: '新建定时任务'
+      new: '新建定时任务',
+      empty_name: '定时任务名称不能为空'
     }
   },
   air: {

diff --git a/src/pages/schedule/edit.vue b/src/pages/schedule/edit.vue
@@ -43,7 +43,12 @@ export default {
       'deleteSchedule'
     ]),
     handleUpdate() {
+      /** @type {ApiTypes.V3.Schedule} */
       const schedule = this.$refs.detail.getSchedule();
+      if (schedule.name.trim().length <= 0) {
+        this.$message.error(this.$t('schedule.edit.empty_name'));
+        return;
+      }
       this.updateSchedule(schedule)
         .then(() => this.$router.push({ name: 'schedule/view', params: { id: this.schedule.id } }))
         .catch(e => this.$message.error(this.$t('plan.edit.update_failed', { code: e.status })));

diff --git a/src/pages/schedule/new.vue b/src/pages/schedule/new.vue
@@ -41,7 +41,12 @@ export default {
       'createSchedule'
     ]),
     handleCreate() {
+      /** @type {ApiTypes.V3.Schedule} */
       const schedule = this.$refs.detail.getSchedule();
+      if (schedule.name.trim().length <= 0) {
+        this.$message.error(this.$t('schedule.edit.empty_name'));
+        return;
+      }
       this.createSchedule(schedule)
         .then(p => this.$router.push({ name: 'schedule/view', params: { id: p.id } }))
         .catch(e => this.$message.error(this.$t('plan.edit.create_failed', { code: e.status })));