Fix flakyness of JedisPooledTest

sazzad16 · Aug 19, 2023 · f38ccbf · f38ccbf
1 parent 155acfd
commit f38ccbf
Showing 1 changed file with 8 additions and 9 deletions.
diff --git a/src/test/java/redis/clients/jedis/JedisPooledTest.java b/src/test/java/redis/clients/jedis/JedisPooledTest.java
@@ -1,10 +1,10 @@
 package redis.clients.jedis;
 
 import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.anything;
 import static org.hamcrest.Matchers.equalTo;
 import static org.hamcrest.Matchers.greaterThanOrEqualTo;
 import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 
@@ -22,6 +22,7 @@
 public class JedisPooledTest {
 
   private static final HostAndPort hnp = HostAndPorts.getRedisServers().get(7);
+  private static final HostAndPort pwp = HostAndPorts.getRedisServers().get(1); // password protected
 
   @Test
   public void checkCloseableConnections() {
@@ -177,17 +178,16 @@ public void testResetValidCredentials() {
     DefaultRedisCredentialsProvider credentialsProvider = 
         new DefaultRedisCredentialsProvider(new DefaultRedisCredentials(null, "bad password"));
 
-    try (JedisPooled pool = new JedisPooled(HostAndPorts.getRedisServers().get(0),
-        DefaultJedisClientConfig.builder().credentialsProvider(credentialsProvider)
-            .clientName("my_shiny_client_name").build())) {
+    try (JedisPooled pool = new JedisPooled(pwp, DefaultJedisClientConfig.builder()
+        .credentialsProvider(credentialsProvider).build())) {
       try {
         pool.get("foo");
         fail("Should not get resource from pool");
       } catch (JedisException e) { }
       assertEquals(0, pool.getPool().getNumActive());
 
       credentialsProvider.setCredentials(new DefaultRedisCredentials(null, "foobared"));
-      assertNull(pool.get("foo"));
+      assertThat(pool.get("foo"), anything());
     }
   }
 
@@ -238,9 +238,8 @@ public void cleanUp() {
     GenericObjectPoolConfig<Connection> poolConfig = new GenericObjectPoolConfig<>();
     poolConfig.setMaxTotal(1);
     poolConfig.setTestOnBorrow(true);
-    try (JedisPooled pool = new JedisPooled(HostAndPorts.getRedisServers().get(0),
-        DefaultJedisClientConfig.builder().credentialsProvider(credentialsProvider)
-            .build(), poolConfig)) {
+    try (JedisPooled pool = new JedisPooled(pwp, DefaultJedisClientConfig.builder()
+        .credentialsProvider(credentialsProvider).build(), poolConfig)) {
       try {
         pool.get("foo");
         fail("Should not get resource from pool");
@@ -251,7 +250,7 @@ public void cleanUp() {
       assertThat(cleanupCount.getAndSet(0), greaterThanOrEqualTo(1));
 
       validPassword.set(true);
-      assertNull(pool.get("foo"));
+      assertThat(pool.get("foo"), anything());
       assertThat(prepareCount.get(), equalTo(1));
       assertThat(cleanupCount.get(), equalTo(1));
     }