Remove version suffix

sazzad16 · Sep 4, 2023 · 9498a4d · 9498a4d
1 parent fd56dda
commit 9498a4d
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 22 deletions.
diff --git a/src/main/java/redis/clients/jedis/Connection.java b/src/main/java/redis/clients/jedis/Connection.java
@@ -432,10 +432,6 @@ private void initializeFromClientConfig(final JedisClientConfig config) {
 
         String libVersion = JedisMetaInfo.getVersion();
         if (libVersion != null && validateClientInfo(libVersion)) {
-          String libVerSuffix = setInfoConfig.libVerSuffix();
-          if (libVerSuffix != null && validateClientInfo(libVerSuffix)) {
-            libVersion = libVersion + libVerSuffix;
-          }
           fireAndForgetMsg.add(new CommandArguments(Command.CLIENT).add(Keyword.SETINFO)
               .add(ClientAttributeOption.LIB_VER.getRaw()).add(libVersion));
         }

diff --git a/src/main/java/redis/clients/jedis/DefaultJedisClientConfig.java b/src/main/java/redis/clients/jedis/DefaultJedisClientConfig.java
@@ -266,7 +266,6 @@ public static class SetInfoBuilder {
 
     private boolean disable = false;
     private String libNameSuffix = null;
-    private String libVerSuffix = null;
 
     private SetInfoBuilder() {
     }
@@ -283,11 +282,6 @@ public boolean disable() {
         public String libNameSuffix() {
           return libNameSuffix;
         }
-
-        @Override
-        public String libVerSuffix() {
-          return libVerSuffix;
-        }
       };
     }
 
@@ -300,11 +294,6 @@ public SetInfoBuilder libNameSuffix(String suffix) {
       this.libNameSuffix = suffix;
       return this;
     }
-
-    public SetInfoBuilder libVerSuffix(String suffix) {
-      this.libVerSuffix = suffix;
-      return this;
-    }
   }
 
   public static DefaultJedisClientConfig create(int connectionTimeoutMillis, int soTimeoutMillis,

diff --git a/src/main/java/redis/clients/jedis/JedisClientConfig.java b/src/main/java/redis/clients/jedis/JedisClientConfig.java
@@ -89,10 +89,6 @@ default boolean disable() {
     default String libNameSuffix() {
       return null;
     }
-
-    default String libVerSuffix() {
-      return null;
-    }
   }
 
   default ClientSetInfoConfig getClientSetInfoConfig() {

diff --git a/src/test/java/redis/clients/jedis/JedisTest.java b/src/test/java/redis/clients/jedis/JedisTest.java
@@ -317,15 +317,13 @@ public void clientSetInfoDisable() {
   @Test
   public void clientSetInfoCustom() {
     final String libNameSuffix = "-for-redis";
-    final String libVerSuffix = "-custom";
     ClientSetInfoConfig setInfoConfig = DefaultJedisClientConfig.setInfoBuilder()
-        .libNameSuffix(libNameSuffix).libVerSuffix(libVerSuffix).build();
+        .libNameSuffix(libNameSuffix).build();
     try (Jedis jedis = new Jedis(hnp, DefaultJedisClientConfig.builder().password("foobared")
         .clientSetInfoConfig(setInfoConfig).build())) {
       assertEquals("PONG", jedis.ping());
       String info = jedis.clientInfo();
       assertTrue(info.contains("lib-name=" + JedisMetaInfo.getArtifactId() + libNameSuffix));
-      assertTrue(info.contains("lib-ver=" + JedisMetaInfo.getVersion() + libVerSuffix));
     }
   }