Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Polish twenties #345

Merged
merged 5 commits into from
Aug 16, 2022

Conversation

cyriaka90
Copy link
Contributor

@cyriaka90 cyriaka90 commented Nov 9, 2020

Fixes # by...

Changes proposed in this pull request:

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

Polish should output dziewięćdziesiąt instead of dziewięćdzisiąt for 90

Additional notes

Seems to be a typo.

Sorry, something went wrong.

@coveralls
Copy link

coveralls commented Nov 9, 2020

Pull Request Test Coverage Report for Build 2868239431

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 96.545%

Totals Coverage Status
Change from base Build 2868235230: 0.03%
Covered Lines: 7125
Relevant Lines: 7303

💛 - Coveralls

@cyriaka90 cyriaka90 force-pushed the fix_polish_twenty branch from f705a7b to 690ca31 Compare May 17, 2021 08:53
@cyriaka90
Copy link
Contributor Author

Any updates here? :)

@cyriaka90
Copy link
Contributor Author

@mromdhane do you know why the checks aren't completing after I merged master?

@egorvavilov
Copy link

Hey, guys
Do you need help with this one? Because it is an issue for 2 years already!)

@cyriaka90
Copy link
Contributor Author

It's really just correcting typos. Don't know why the maintainers didn't take a look yet. :/

egorvavilov
egorvavilov previously approved these changes Mar 30, 2022
Copy link

@egorvavilov egorvavilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes to polish version of words are correct
@mromdhane can you include PR into future release?)

Copy link

@PlusSP PlusSP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls accept it

@PlusSP
Copy link

PlusSP commented Apr 7, 2022

we need this change, pls merge it

Copy link

@PlusSP PlusSP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls accept it

@cyriaka90
Copy link
Contributor Author

@mrodriguezg1991 maybe? or @mromdhane?

PlusSP
PlusSP previously approved these changes Apr 7, 2022
Copy link

@PlusSP PlusSP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i approve

@mrodriguezg1991
Copy link
Contributor

@cyriaka90 Hello and thanks for the contribution
The test coverage seems to drop with this change, can you add some tests??

@cyriaka90
Copy link
Contributor Author

@cyriaka90 Hello and thanks for the contribution The test coverage seems to drop with this change, can you add some tests??

It's really odd, since I only changed the spelling and didn't really add anything. But I'll add some tests. :)

@cyriaka90 cyriaka90 dismissed stale reviews from PlusSP and egorvavilov via 3715260 August 16, 2022 13:00

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@cyriaka90
Copy link
Contributor Author

Test coverage seems to be fine now :)

@cyriaka90 cyriaka90 mentioned this pull request Aug 16, 2022
3 tasks

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@mrodriguezg1991 mrodriguezg1991 merged commit 540c5bd into savoirfairelinux:master Aug 16, 2022
@cyriaka90 cyriaka90 deleted the fix_polish_twenty branch August 16, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants