Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix. KDoc @return tag is suggested for extension functions which return Unit #507

Merged
merged 3 commits into from
Nov 11, 2020

Conversation

aktsay6
Copy link
Collaborator

@aktsay6 aktsay6 commented Nov 10, 2020

What's done:

This pull request closes #489

### What's done:
  * Fixed bugs
  * Smoke test #1 reworked
@aktsay6 aktsay6 added the bug Something isn't working label Nov 10, 2020
@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #507 (3615ace) into master (48eec27) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #507   +/-   ##
=========================================
  Coverage     81.80%   81.80%           
  Complexity     1547     1547           
=========================================
  Files            73       73           
  Lines          3892     3892           
  Branches       1242     1242           
=========================================
  Hits           3184     3184           
  Misses          210      210           
  Partials        498      498           
Flag Coverage Δ Complexity Δ
unittests 81.80% <100.00%> (ø) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../org/cqfn/diktat/ruleset/rules/kdoc/KdocMethods.kt 90.19% <100.00%> (ø) 69.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48eec27...96261ee. Read the comment docs.

@aktsay6 aktsay6 merged commit dad0572 into master Nov 11, 2020
@aktsay6 aktsay6 deleted the bugfix/extension-function-kdoc(#489) branch November 11, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KDoc @return tag is suggested for extension functions which return Unit
2 participants