Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle-plugin: fix incorrect dependencies related to SarifReportMergeTask #1485

Merged
merged 1 commit into from Jul 29, 2022

Conversation

petertrr
Copy link
Member

What's done:

  • Added missing dependency in diktat-gradle-plugin/pom.xml
  • Fixed typo in logging

This pull request is part of #1484. It fixes compilation of gradle scripts for projects that don't have kotlinx-serialization-core on their plugin classpath.

…Task

### What's done:
* Added missing dependency in `diktat-gradle-plugin/pom.xml`
* Fixed typo in logging
@petertrr petertrr enabled auto-merge (squash) July 29, 2022 15:34
@petertrr petertrr added this to the 1.2.3 milestone Jul 29, 2022
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #1485 (40a96c4) into master (2a14294) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1485   +/-   ##
=========================================
  Coverage     82.96%   82.96%           
  Complexity     2579     2579           
=========================================
  Files           111      111           
  Lines          7708     7708           
  Branches       2111     2111           
=========================================
  Hits           6395     6395           
  Misses          418      418           
  Partials        895      895           
Flag Coverage Δ
unittests 82.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...diktat/plugin/gradle/tasks/SarifReportMergeTask.kt 18.91% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a14294...40a96c4. Read the comment docs.

@github-actions
Copy link
Contributor

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

1 317 tests   1 302 ✔️  1m 20s ⏱️
   161 suites       15 💤
   161 files           0

Results for commit 40a96c4.

@github-actions
Copy link
Contributor

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

1 332 tests   1 317 ✔️  2m 55s ⏱️
   162 suites       15 💤
   162 files           0

Results for commit 40a96c4.

@petertrr petertrr merged commit d354d88 into master Jul 29, 2022
@petertrr petertrr deleted the bugfix/merge-sarif#1484 branch July 29, 2022 16:15
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 removed this from the 1.2.3 milestone Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle plug-in no longer works w/o the :mergeDiktatReports task
3 participants