Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added release action #84

Merged
merged 5 commits into from Sep 21, 2020
Merged

Added release action #84

merged 5 commits into from Sep 21, 2020

Conversation

mciastek
Copy link
Contributor

This PR adds manual release action via Github Actions. Also it adds removing ANSI escape codes to snapshot serialization in order to make test pass on all platforms.

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2020

Codecov Report

Merging #84 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files           6        6           
  Lines         383      383           
  Branches       84       84           
=======================================
  Hits          380      380           
  Misses          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1defb34...c3074ec. Read the comment docs.

Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we get rid of Travis all together and also have the tests run on GitHub Actions?

- name: Setup Node version
uses: actions/setup-node@v1
with:
node-version: 10.15.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the node version to latest LTS (including in .nvmrc)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this action (setup-node) doesn't support keywords like lts, see actions/setup-node#58. I can bump Node version to match current LTS, but until the PR is merged we will need to do it manually.

.github/workflows/npm-publish.yml Outdated Show resolved Hide resolved
@mciastek
Copy link
Contributor Author

How about we get rid of Travis all together and also have the tests run on GitHub Actions?

It's a good idea, although I would like to do it in other PR maybe, because we will introduce too many changes. What do you think?

@mciastek
Copy link
Contributor Author

I found pretty nice tool for testing Github Actions locally (via Docker containers) - https://github.com/nektos/act. Unfortunately, we still need to test the workflow after merging it to master, because act doesn't support any actions that requires Github API like artifacts and caching.

.github/workflows/npm-publish.yml Outdated Show resolved Hide resolved
.github/workflows/npm-publish.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@farhan-sauce farhan-sauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Lets wait for Christian's approval.

Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I created a follow up ticket: #85

@mciastek mciastek merged commit ed563f0 into master Sep 21, 2020
@mciastek mciastek deleted the feat/add_release_action branch September 21, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants