Add insecure option #289
Merged
Add insecure option #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
reviewed
Sep 24, 2020
| * | ||
| * @return bool | ||
| */ | ||
| protected function executeApi(Configuration $config) | ||
| protected function executeApi(InputInterface $input, Configuration $config) |
There was a problem hiding this comment.
this looks like a BC breaker, as this class is not marked with an internal. can you think about way to bring this feature without BC break ?
There was a problem hiding this comment.
Could you check this solution, please?
dshemin
force-pushed
the
feature-allow-insecure-connection
branch
from
b52b390
to
a50e95c
Compare
dshemin
force-pushed
the
feature-allow-insecure-connection
branch
from
a50e95c
to
f21fa35
Compare
Thanks! I pushed new changes. |
|
There are still some CS irregularities, unfortunately: |
dshemin
force-pushed
the
feature-allow-insecure-connection
branch
2 times, most recently
from
87df3f9
to
d3c7dc2
Compare
|
Can anyone help me with this error, please? I'm really cannot understand what is wrong 'cause locally I didn't see this error. |
|
Try “composer update” maybe? |
dshemin
force-pushed
the
feature-allow-insecure-connection
branch
from
d3c7dc2
to
ad46796
Compare
dshemin
force-pushed
the
feature-allow-insecure-connection
branch
from
ad46796
to
749a466
Compare
|
Looks like everything is okay. Please take a look again at this pull request. |
keradus
approved these changes
Oct 5, 2020
reececomo
pushed a commit
to reececomo/php-coveralls
that referenced
this pull request
Jan 15, 2021
* Update .travis.yml to include PHP 7.4 (php-coveralls#283) * Fix incorrect version in README (php-coveralls#286) * Add Guzzle 7 support (php-coveralls#288) * Add Guzzle 7 support * Update composer.json Co-authored-by: Dariusz Rumiński <dariusz.ruminski@gmail.com> * DX: Configurator - reduce cyclomatic complexity (php-coveralls#291) * CI: reduce amount of jobs (php-coveralls#292) * Allow to specify endpoint in arguments (php-coveralls#290) * Allow to specify endpoint in arguments * use new helper Co-authored-by: Dariusz Ruminski <dariusz.ruminski@gmail.com> * DX: Allow PHPUnit 7 (php-coveralls#294) * Added COVERALLS_PARALLEL support and Configured CI_BUILD_NUMBER for Travis CI (php-coveralls#279) * updated to detect COVERALLS_PARALLEL env var * added CI_BUILD_NUMBER into Configuration * updated README * fixed tests * Update RequirementsNotSatisfiedException.php * fix CS * fix checking of required fields + tests * add missing class property Co-authored-by: Dariusz Rumiński <dariusz.ruminski@gmail.com> * Prepare v2.3.0 * Add support for PHP 8 + PHPUnit 9 (php-coveralls#295) * Add support for PHP 8 + PHPUnit 9 * Add PHPUnit 4.8 workarounds * Do --ignore-platform-reqs on PHP 8 * Skip failing test due to missing get_debug_type() * Add insecure option (php-coveralls#289) * Add Github Actions and COVERALLS_FLAG_NAME support (php-coveralls#296) Co-authored-by: Smolevich <smolevich90@gmail.com> Co-authored-by: Simon Podlipsky <simon@podlipsky.net> * DX: .gitignore cache PHPUnit (php-coveralls#297) * Prepare v2.4.0 * Fix support of branch name with hyphen and "(no branch)" (php-coveralls#298) * Fix no-branch on CI error * fix support of dash in branch names * little tests cleanup * Prepare v2.4.1 * Correct spelling error in Github (php-coveralls#299) * Add COVERALLS_REPO_TOKEN to error message when run on Github Action (php-coveralls#302) * Update README.md (php-coveralls#303) Version 2.4.0 does not have a phar file, change to v2.4.2 * Add file missing for PHP 8 (php-coveralls#308) fixes php-coveralls#307 * Prepare v2.4.3 * Update CiEnvVarsCollector.php Re-arrange methods to avoid merge conflicts with upstream * Update JsonFileTest.php Remove duplicate method `shouldSetParallel()` * Update JsonFile.php Remove duplicate property `$parallel` * Update JsonFile.php Remove duplicate method `setParallel()` * Update CiEnvVarsCollector.php Fix code style * Update JsonFileTest.php Fix broken test Co-authored-by: Alexey Kopytko <alexey@kopytko.com> Co-authored-by: Viktor Szépe <viktor@szepe.net> Co-authored-by: Dmitry Ivanov <dmitry.g.ivanov@gmail.com> Co-authored-by: Dariusz Rumiński <dariusz.ruminski@gmail.com> Co-authored-by: Dmitry Shemin <shemindmitry@gmail.com> Co-authored-by: Yih Yang <yyngo788n88@hotmail.com> Co-authored-by: Twin Huang <twinhuang@qq.com> Co-authored-by: Smolevich <smolevich90@gmail.com> Co-authored-by: Simon Podlipsky <simon@podlipsky.net> Co-authored-by: Danny van der Sluijs <danny.vandersluijs@icloud.com> Co-authored-by: Oanh Nguyen <oanhnn.bk@gmail.com> Co-authored-by: Jimmy Cleuren <jimmy.cleuren@gmail.com> Co-authored-by: Christian Raue <christian.raue@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it will be nice to have the ability to send coverage reports to self-hosted service with self-signed certificates. For instance
goverallshave such ability.