Add support for PHP 8 + PHPUnit 9 #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
reviewed
Sep 25, 2020
| @@ -17,6 +17,8 @@ jobs: | |||
| env: SYMFONY_VERSION="^5.0" MIN_STABILITY=dev | |||
| - php: 7.4 | |||
| env: CHECKS=yes | |||
| - php: nightly | |||
| env: 'COMPOSER_FLAGS="--ignore-platform-reqs"' | |||
There was a problem hiding this comment.
open question: what is failing without it ?
There was a problem hiding this comment.
phpunit/phpunit 9.3.9 requires phpspec/prophecy, but it is not installable on PHP 8.
Here's a relevant discussion with the man himself: phpspec/prophecy#491 (comment)
keradus
reviewed
Sep 25, 2020
| @@ -41,7 +41,8 @@ | |||
| "symfony/yaml": "^2.0.5 || ^3.0 || ^4.0 || ^5.0" | |||
| }, | |||
| "require-dev": { | |||
| "phpunit/phpunit": "^4.8.35 || ^5.4.3 || ^6.0 || ^7.0" | |||
| "phpunit/phpunit": "^4.8.35 || ^5.4.3 || ^6.0 || ^7.0 || ^8.0 || ^9.0", | |||
| "sanmai/phpunit-legacy-adapter": "^6.1 || ^8.0" | |||
There was a problem hiding this comment.
i do understand the need and the approach.
I'm still crying internally.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
keradus
approved these changes
Sep 25, 2020
|
thanks @sanmai |
Closed
|
|
|
i wanna see can we do #289 in the same release, first. thanks for understanding |
|
Thank you for 2.4.0! 🎉 |
reececomo
pushed a commit
to reececomo/php-coveralls
that referenced
this pull request
Jan 15, 2021
* Update .travis.yml to include PHP 7.4 (php-coveralls#283) * Fix incorrect version in README (php-coveralls#286) * Add Guzzle 7 support (php-coveralls#288) * Add Guzzle 7 support * Update composer.json Co-authored-by: Dariusz Rumiński <dariusz.ruminski@gmail.com> * DX: Configurator - reduce cyclomatic complexity (php-coveralls#291) * CI: reduce amount of jobs (php-coveralls#292) * Allow to specify endpoint in arguments (php-coveralls#290) * Allow to specify endpoint in arguments * use new helper Co-authored-by: Dariusz Ruminski <dariusz.ruminski@gmail.com> * DX: Allow PHPUnit 7 (php-coveralls#294) * Added COVERALLS_PARALLEL support and Configured CI_BUILD_NUMBER for Travis CI (php-coveralls#279) * updated to detect COVERALLS_PARALLEL env var * added CI_BUILD_NUMBER into Configuration * updated README * fixed tests * Update RequirementsNotSatisfiedException.php * fix CS * fix checking of required fields + tests * add missing class property Co-authored-by: Dariusz Rumiński <dariusz.ruminski@gmail.com> * Prepare v2.3.0 * Add support for PHP 8 + PHPUnit 9 (php-coveralls#295) * Add support for PHP 8 + PHPUnit 9 * Add PHPUnit 4.8 workarounds * Do --ignore-platform-reqs on PHP 8 * Skip failing test due to missing get_debug_type() * Add insecure option (php-coveralls#289) * Add Github Actions and COVERALLS_FLAG_NAME support (php-coveralls#296) Co-authored-by: Smolevich <smolevich90@gmail.com> Co-authored-by: Simon Podlipsky <simon@podlipsky.net> * DX: .gitignore cache PHPUnit (php-coveralls#297) * Prepare v2.4.0 * Fix support of branch name with hyphen and "(no branch)" (php-coveralls#298) * Fix no-branch on CI error * fix support of dash in branch names * little tests cleanup * Prepare v2.4.1 * Correct spelling error in Github (php-coveralls#299) * Add COVERALLS_REPO_TOKEN to error message when run on Github Action (php-coveralls#302) * Update README.md (php-coveralls#303) Version 2.4.0 does not have a phar file, change to v2.4.2 * Add file missing for PHP 8 (php-coveralls#308) fixes php-coveralls#307 * Prepare v2.4.3 * Update CiEnvVarsCollector.php Re-arrange methods to avoid merge conflicts with upstream * Update JsonFileTest.php Remove duplicate method `shouldSetParallel()` * Update JsonFile.php Remove duplicate property `$parallel` * Update JsonFile.php Remove duplicate method `setParallel()` * Update CiEnvVarsCollector.php Fix code style * Update JsonFileTest.php Fix broken test Co-authored-by: Alexey Kopytko <alexey@kopytko.com> Co-authored-by: Viktor Szépe <viktor@szepe.net> Co-authored-by: Dmitry Ivanov <dmitry.g.ivanov@gmail.com> Co-authored-by: Dariusz Rumiński <dariusz.ruminski@gmail.com> Co-authored-by: Dmitry Shemin <shemindmitry@gmail.com> Co-authored-by: Yih Yang <yyngo788n88@hotmail.com> Co-authored-by: Twin Huang <twinhuang@qq.com> Co-authored-by: Smolevich <smolevich90@gmail.com> Co-authored-by: Simon Podlipsky <simon@podlipsky.net> Co-authored-by: Danny van der Sluijs <danny.vandersluijs@icloud.com> Co-authored-by: Oanh Nguyen <oanhnn.bk@gmail.com> Co-authored-by: Jimmy Cleuren <jimmy.cleuren@gmail.com> Co-authored-by: Christian Raue <christian.raue@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Replace #293
Fix #281