Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message(s) to console output #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pmrotule
Copy link

@pmrotule pmrotule commented Apr 25, 2017

The message logged on error was only including the error count and the file where the error occurred. Hence I modified the code to print the error message(s) on the next line. The message logged in the console now look like this:

Message:
    1 error detected in 4.elements/images.scss
        - Please check validity of the block starting from line #14
    2 errors detected in 6.templates/help-center-nav.scss
        - Please check validity of the block starting from line #46
        - Another error
Details:
    domainEmitter: [object Object]
    domain: [object Object]
    domainThrown: false

...instead of:

Message:
    1 errors detected in 4.elements/images.scss
2 errors detected in 6.templates/help-center-nav.scss
Details:
    domainEmitter: [object Object]
    domain: [object Object]
    domainThrown: false

My modifications are made in ES6.

The message logged on error was only including the error count and the file where the error occurred. Hence I modified the code to print the error message(s) on the next line.
@JetFault
Copy link

Can we add this? This is really useful if you need both an output file and want to know what happened in the console

@caseycallow
Copy link

+1 for this

@d-luk
Copy link

d-luk commented Apr 9, 2018

Is there any reason for this not being merged? This is a necessary feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants