Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rake gem:native task #196

Merged
merged 1 commit into from Apr 17, 2020
Merged

Conversation

casperisfine
Copy link

As discussed in #195, rake gem:native is currently broken, preventing a new release.

The error is:

Package g++-multilib is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'g++-multilib' has no installation candidate
rake aborted!

I looked around and apparently this package is outdated an no longer available. However it's used for cross compiling for 32bit packages.

If we looked at downloaded packages:

I think it's safe to say that close to nobody downloads the 32 bits binaries, and for the few people who do, AFAIK it should fallback somewhat nicely to compiling from source.

All that to say that I think it's OK to drop it.

cc @bolandrm @rafaelfranca

@casperisfine
Copy link
Author

Additionally f26f2a1 removed precompilation for linux, so really the only precompilation left is x64-mingw32.

I tested it locally and it works:

$ ls pkg/
sassc-2.2.1-x64-mingw32     sassc-2.2.1-x64-mingw32.gem sassc-2.2.1.gem

@glebm
Copy link
Contributor

glebm commented Apr 16, 2020

A better fix would be to remove this install command:

RakeCompilerDock.sh "sudo apt-get install -y g++-multilib && gem i rake bundler --no-document && bundle && "\

This is now handled in rake-compiler itself

@casperisfine
Copy link
Author

Well, that's what this PR does.

I pushed a new commit that adds x86-mingw32 back.

@glebm
Copy link
Contributor

glebm commented Apr 16, 2020

Please update the commit message as well

@casperisfine casperisfine changed the title Drop 32bit packages because g++-multilib is no longer available Fix rake gem:native task Apr 16, 2020
@casperisfine
Copy link
Author

Please update the commit message as well

RIght, good point. Done.

@bolandrm
Copy link
Member

Thanks. Will release tomorrow morning assuming i don't run into any issues.

@bolandrm bolandrm merged commit 1bc1c54 into sass:master Apr 17, 2020
@bolandrm
Copy link
Member

Release complete, thanks for the help!

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request May 17, 2020
Update to ruby-sassc to 2.3.0.


- **2.3.0**
  - [Fix rake gem:native task](sass/sassc-ruby#196)
  - [disable lto flag for darwin + nix](sass/sassc-ruby#166)
  - [Sort input file list](sass/sassc-ruby#178)
  - [Set appropriate encoding for source_map](sass/sassc-ruby#152)
  - [allow passing functions directly](sass/sassc-ruby#162)
  - [always dispose data context](sass/sassc-ruby#161)
  - [Update libsass to 3.6.3](sass/sassc-ruby#164)
  - [Restore strip symbols](sass/sassc-ruby#184)
  - [Default --march-tune-native to false](sass/sassc-ruby#158)
  - [Fix compile issue on Mac OS X](sass/sassc-ruby#174)
  - [Test on TruffleRuby in TravisCI](sass/sassc-ruby#171)
  - [Use RbConfig::MAKEFILE_CONFIG['DLEXT'] instead of hardcoding extensions](sass/sassc-ruby#173)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants