Use RbConfig::MAKEFILE_CONFIG['DLEXT'] instead of hardcoding extensions #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Since libsass is meant to be used with FFI, RbConfig::CONFIG['SOEXT'] would be better, but DLEXT is used as libsass is compiled by mkmf (sass#127). * Use RbConfig::MAKEFILE_CONFIG['DLEXT'] instead of just RbConfig::CONFIG['DLEXT'] so it's also correct on JRuby and not 'jar'. See https://github.com/rake-compiler/rake-compiler/blob/f808dd7a/lib/rake/extensiontask.rb#L41 * This lets Ruby implementations use another file extension than .so/.bundle for C extensions. For example, TruffleRuby 19.3.0 uses .dylib on macOS. * Some OS also use a different file extension, such as HPUX which uses .sl.
glebm
approved these changes
Nov 24, 2019
Closed
|
@bolandrm Could you merge this? |
|
@bolandrm Thank you for merging! If it's not too much trouble, would it be possible to make a release of |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
May 17, 2020
Update to ruby-sassc to 2.3.0. - **2.3.0** - [Fix rake gem:native task](sass/sassc-ruby#196) - [disable lto flag for darwin + nix](sass/sassc-ruby#166) - [Sort input file list](sass/sassc-ruby#178) - [Set appropriate encoding for source_map](sass/sassc-ruby#152) - [allow passing functions directly](sass/sassc-ruby#162) - [always dispose data context](sass/sassc-ruby#161) - [Update libsass to 3.6.3](sass/sassc-ruby#164) - [Restore strip symbols](sass/sassc-ruby#184) - [Default --march-tune-native to false](sass/sassc-ruby#158) - [Fix compile issue on Mac OS X](sass/sassc-ruby#174) - [Test on TruffleRuby in TravisCI](sass/sassc-ruby#171) - [Use RbConfig::MAKEFILE_CONFIG['DLEXT'] instead of hardcoding extensions](sass/sassc-ruby#173)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RbConfig::CONFIG['SOEXT']would be better, but DLEXT is used as libsass is compiled by mkmf (Link C/C++ stdlib statically for binary gems #127).
RbConfig::MAKEFILE_CONFIG['DLEXT']instead of justRbConfig::CONFIG['DLEXT']so it's also correct on JRuby and not 'jar'. See
https://github.com/rake-compiler/rake-compiler/blob/f808dd7a/lib/rake/extensiontask.rb#L41
for C extensions. For example, TruffleRuby 19.3.0 uses .dylib on macOS.
This allows
sasscto work again on TruffleRuby on macOS: oracle/truffleruby#1819cc @bolandrm @glebm