[Color 4] Be stricter about slash-separated strings #3862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goodwine
reviewed
May 10, 2024
accepted/color-4-new-spaces.md
Outdated
| @@ -1141,26 +1141,17 @@ The procedure is: | |||
| * Let `split-last` be the result calling `string.split()` with the last | |||
| element of `input` as the string to split, and `/` as the separator. | |||
|
|
|||
| * If `split-last` has two items, and one or both items are an unquoted | |||
| string that's case-insensitively equal to 'none': | |||
| * If `split-last` doesn't have exactly two items, throw an error. | |||
There was a problem hiding this comment.
Is this meant to deal with the following case?
rgba(1 2 calc(var(--x)/var(--x))/var(--x))IIUC by this point components == [1, 2] and split-last == [calc(var(--x), var(--x)), var(--x)] which would fail, however I think it should technically be permitted 🤔
There was a problem hiding this comment.
Hmm, that's an interesting point. I think you're right that allowing that is more important than disallowing rgb(1 2 3 a/b/c/).
Goodwine
approved these changes
May 10, 2024
Co-authored-by: Carlos (Goodwine) <2022649+Goodwine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.