[Color 4] Various fixes #3858
Merged
[Color 4] Various fixes #3858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, you get weird behavior when conversion to the XYZ space preserves missing channels, which can cause colors to be considered `same()` even when they're visually distinct.
nex3
force-pushed
the
same-zero-before-conversion
branch
from
88995ea
to
2cde27c
Compare
nex3
changed the title
color.same()
nex3
force-pushed
the
same-zero-before-conversion
branch
from
745f59f
to
0026eae
Compare
Goodwine
approved these changes
May 2, 2024
Goodwine
reviewed
May 2, 2024
Now that `color.same()` explicitly treats missing channels as 0, it makes more sense for `==` to fill the stricter role and treat them as different. This is especially true because it already requires (non-legacy) colors to be in the same space, so missing channels are much more consistently meaningful than they would be in cross-space comparisons.
nex3
force-pushed
the
same-zero-before-conversion
branch
from
0026eae
to
ca967a4
Compare
Goodwine
approved these changes
May 2, 2024
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
May 3, 2024
nex3
changed the title
nex3
force-pushed
the
same-zero-before-conversion
branch
from
c939218
to
97d6902
Compare
nex3
force-pushed
the
same-zero-before-conversion
branch
from
97d6902
to
c8fe2ed
Compare
Goodwine
approved these changes
May 8, 2024
mirisuzanne
approved these changes
May 8, 2024
Goodwine
approved these changes
May 9, 2024
| @@ -2300,7 +2306,8 @@ ie-hex-str($color) | |||
|
|
|||
| * If `$color` is not a color, throw an error. | |||
|
|
|||
| * Let `rgb` be the result of [converting] and [gamut mapping] `$color` to `rgb`. | |||
| * Let `rgb` be the result of [converting] and [gamut mapping] `$color` to `rgb` | |||
There was a problem hiding this comment.
Nit: it feels a little odd that rgb here stands for a variable and for a channel
There was a problem hiding this comment.
It's pretty common here to use the name of a color space to represent "the current color in that space". It is a bit odd but I think not so much that a reader can't get used to it, and it's substantially terser than using something like rgbColor everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zero missing channels before conversion in
color.same()Otherwise, you get weird behavior when conversion to the XYZ space preserves missing channels, which can cause colors to be considered
same()even when they're visually distinct.Treat missing channels as distinct from 0 for
==Now that
color.same()explicitly treats missing channels as 0, it makes more sense for==to fill the stricter role and treat them as different. This is especially true because it already requires (non-legacy) colors to be in the same space, so missing channels are much more consistently meaningful than they would be in cross-space comparisons.Improve specifications for missing alpha values