Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Floating Point] Integrate the proposal into the spec #3408

Merged
merged 2 commits into from Oct 3, 2022

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Oct 3, 2022

Closes #2892

@nex3 nex3 requested a review from jathak October 3, 2022 22:09
@nex3 nex3 mentioned this pull request Oct 3, 2022
4 tasks
@@ -71,6 +119,10 @@ ceil($number)

This function is also available as a global function named `ceil()`.

* Return a number whose value is the result of
`convertToIntegerTowardPositive($number.value)` as defined by [IEEE 754 2019],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link for [IEEE 754 2019] isn't defined anywhere in this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops!

@nex3 nex3 merged commit 78d28d3 into main Oct 3, 2022
@nex3 nex3 deleted the floating-point.integrate branch October 3, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use floating-point numbers universally
2 participants