Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proposal for Function and Values API #3076

Merged
merged 19 commits into from
Aug 2, 2021
Merged

Conversation

Awjin
Copy link
Contributor

@Awjin Awjin commented Jun 11, 2021

This proposal specifies the behavior of custom functions and Sass values in the new JS API.

Fixes #2510 and partially addresses #3056.

@Awjin Awjin marked this pull request as draft June 11, 2021 17:13
@Awjin Awjin marked this pull request as ready for review July 29, 2021 23:18
@Awjin Awjin requested a review from nex3 July 29, 2021 23:18
proposal/new-function-and-values-api.d.ts Outdated Show resolved Hide resolved
proposal/new-function-and-values-api.d.ts Outdated Show resolved Hide resolved
The use of OrderedMap to enforce immutability should be an
implementation detail.
@Awjin Awjin requested a review from nex3 July 31, 2021 00:09
Copy link
Contributor

@nex3 nex3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@Awjin Awjin merged commit 1cc38d2 into main Aug 2, 2021
@Awjin Awjin deleted the new-function-values-api branch August 2, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overhaul JS Function API
2 participants