New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Units dropped from random() $limit #1890
Comments
Is the desire to have |
@jcutrell No, the desire is to (ultimately) have |
Blocking until feedback arrives from proposal https://github.com/sass/sass/blob/main/proposal/random-with-units.md |
Now that the proposal has landed, we'll give this a month for public comment since it's a low-controversy breaking change. |
@nex3 shouldn't this proposal be announced on the blog if you expect comments on it ? |
Per the contributing guidelines
Assuming that because this enhancement/fix is small and uncontroversial it doesn't cross that threshold 🤔 |
Deprecation added, now waiting on Dart 2.0.0 to implement spec |
Deprecation
Final
(Original:)
The unit passed with the limit should be the unit on the returned value. Instead the unit is dropped and never considered nor is an error raised.
Step 1:
Deprecate passing units to
random()
as the$limit
.Step 2:
Make passing a unit to
random()
as the$limit
an error.Step 3:
Allow units to be passed in, returning them with the random result.
The text was updated successfully, but these errors were encountered: