Add specs for universal floating-point numbers #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 15, 2022
jathak
approved these changes
Sep 15, 2022
stof
reviewed
Sep 17, 2022
| @@ -55,7 +55,7 @@ a {b: math.acos(1.000000000001)} | |||
|
|
|||
| <===> one_fuzzy/output.css | |||
| a { | |||
| b: 0deg; | |||
| b: NaNdeg; | |||
There was a problem hiding this comment.
shouldn't the case of being fuzzy equal to the bound be handled in math.acos instead of returning NaN ?
There was a problem hiding this comment.
OK, I missed sass/sass@498fda6 so this is actually expected
spec/core_functions/math/round.hrx
Outdated
|
|
||
| <===> up/within_precision/output.css | ||
| a { | ||
| b: 1; | ||
| b: 0; |
There was a problem hiding this comment.
This is not consistent with the test name, which says it would round up
There was a problem hiding this comment.
Good call; this test is now redundant with down/within_precision, so I'll remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1819
[skip dart-sass]