Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repro dart-sass#1716 #1796

Merged
merged 7 commits into from Aug 18, 2022
Merged

Repro dart-sass#1716 #1796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
88fb26d
Repro dart-sass#1716
Goodwine Jun 22, 2022
d0a9638
additional case with passing but similar case
Goodwine Jun 22, 2022
75eb8a0
move tests from @forward to @use, make more generic too
Goodwine Jul 14, 2022
357fc32
empty commit
Goodwine Jul 14, 2022
2f2e6ca
use single-leter names for irrelevant placeholders
Goodwine Jul 15, 2022
71922fe
make sure forwarding twice still breaks
Goodwine Jul 18, 2022
43ca565
fix @forward with new opaqueID inheritance logic expectations
Goodwine Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
130 changes: 130 additions & 0 deletions spec/directives/use/error/with.hrx
View file
Open in desktop
Expand Up @@ -351,3 +351,133 @@ Error: This variable was not declared with !default in the @used module.
| ^^^^^
'
input.scss 1:19 root stylesheet

<===>
================================================================================
<===> through_forward_twice/with/input.scss
@use "used" with ($a: input a);

<===> through_forward_twice/with/_used.scss
@forward "forwarded" with ($a: used a 1 !default);
@forward "forwarded" with ($a: used a 2 !default);

<===> through_forward_twice/with/_forwarded.scss
$a: forwarded a !default;
$b: forwarded b !default;

<===> through_forward_twice/with/error
Error: This module was already loaded, so it can't be configured using "with".
,
1 | @forward "forwarded" with ($a: used a 1 !default);
| ================================================= original load
2 | @forward "forwarded" with ($a: used a 2 !default);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ new load
'
_used.scss 2:1 @use
input.scss 1:1 root stylesheet

<===>
================================================================================
<===> missing_distributed_vars/README.md
A module may load different sets of variables across multiple files triggering
validation of re-using the same module configuration multiple times.

These tests verify the configuration is reused by opaque ID across multiple
source files preventing unexpected behaviors when variables are declared on
separate files with validations that occur when a module is used more than once.


<===>
================================================================================
<===> missing_distributed_vars/single_use/input.scss
@use 'module' with (
$a: 'a',
$b: 'b',
$missing: 'c',
);

<===> missing_distributed_vars/single_use/module/_index.scss
@forward './a/a';
@forward './b/b';

<===> missing_distributed_vars/single_use/module/a/_variables.scss
$a: default !default;

<===> missing_distributed_vars/single_use/module/a/a.scss
@forward './variables';
@use './variables' as *;

.a {
content: #{$a};
}

<===> missing_distributed_vars/single_use/module/b/_variables.scss
$b: default !default;

<===> missing_distributed_vars/single_use/module/b/b.scss
@forward './variables';
@use './variables' as *;

.b {
content: #{$b};
}

<===> missing_distributed_vars/single_use/error
Error: This variable was not declared with !default in the @used module.
,
4 | $missing: 'c',
| ^^^^^^^^^^^^^
'
input.scss 4:3 root stylesheet

<===>
================================================================================
<===> missing_distributed_vars/multi_use/input.scss
@use 'module' with (
$a: 'a',
$b: 'b',
$missing: 'c',
);

<===> missing_distributed_vars/multi_use/module/_index.scss
@forward './a/a1';
@forward './a/a2';
@forward './b/b';

<===> missing_distributed_vars/multi_use/module/a/_variables.scss
$a: default !default;

<===> missing_distributed_vars/multi_use/module/a/a1.scss
@forward './variables';
@use './variables' as *;

.a1 {
content: #{$a};
}

<===> missing_distributed_vars/multi_use/module/a/a2.scss
@forward './variables';
@use './variables' as *;

.a2 {
content: #{$a};
}

<===> missing_distributed_vars/multi_use/module/b/_variables.scss
$b: default !default;

<===> missing_distributed_vars/multi_use/module/b/b.scss
@forward './variables';
@use './variables' as *;

.b {
content: #{$b};
}

<===> missing_distributed_vars/multi_use/error
Error: This variable was not declared with !default in the @used module.
,
4 | $missing: 'c',
| ^^^^^^^^^^^^^
'
input.scss 4:3 root stylesheet
106 changes: 106 additions & 0 deletions spec/directives/use/with.hrx
View file
Open in desktop
Expand Up @@ -581,3 +581,109 @@ b {
midstream1: overridden 1;
midstream2: overridden 2;
}

<===>
================================================================================
<===> distributed_vars/README.md
A module may load different sets of variables across multiple files triggering
validation of re-using the same module configuration multiple times.

These tests verify the configuration is reused by opaque ID across multiple
source files preventing unexpected behaviors when variables are declared on
separate files with validations that occur when a module is used more than once.

<===>
================================================================================
<===> distributed_vars/single_use/input.scss
@use 'module' with (
$a: 'a',
$b: 'b',
);

<===> distributed_vars/single_use/module/_index.scss
@forward './a/a';
@forward './b/b';

<===> distributed_vars/single_use/module/a/_variables.scss
$a: default !default;

<===> distributed_vars/single_use/module/a/a.scss
@forward './variables';
@use './variables' as *;

.a {
content: #{$a};
}

<===> distributed_vars/single_use/module/b/_variables.scss
$b: default !default;

<===> distributed_vars/single_use/module/b/b.scss
@forward './variables';
@use './variables' as *;

.b {
content: #{$b};
}

<===> distributed_vars/single_use/output.css
.a {
content: a;
}
.b {
content: b;
}

<===>
================================================================================
<===> distributed_vars/repeated/input.scss
@use 'module' with (
$a: 'a',
$b: 'b',
);

<===> distributed_vars/repeated/module/_index.scss
@forward './a/a1';
@forward './a/a2';
@forward './b/b';

<===> distributed_vars/repeated/module/a/_variables.scss
$a: default !default;

<===> distributed_vars/repeated/module/a/a1.scss
@forward './variables';
@use './variables' as *;

.a1 {
content: #{$a};
}

<===> distributed_vars/repeated/module/a/a2.scss
@forward './variables';
@use './variables' as *;

.a2 {
content: #{$a};
}

<===> distributed_vars/repeated/module/b/_variables.scss
$b: default !default;

<===> distributed_vars/repeated/module/b/b.scss
@forward './variables';
@use './variables' as *;

.b {
content: #{$b};
}

<===> distributed_vars/repeated/output.css
.a1 {
content: a;
}
.a2 {
content: a;
}
.b {
content: b;
}