Update specs to keep trailing comments on the previous line #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
commented
Oct 16, 2019
…s need to be updated
|
I can't approve this because I'm the one who originally opened it, but 👍. |
Goodwine
approved these changes
Jun 1, 2022
|
I discovered I could approve it, I'll wait until the other PR is ready so they go in at the same time |
Goodwine
added a commit
to sass/dart-sass
that referenced
this pull request
Jun 3, 2022
See sass/sass-spec#1485 - Update lib/src/visitor/serialize.dart to stop using old-style int-based for loop. - Extend FileSpan with a .contains(targetSpan) method Co-authored-by: Nick Behrens <nbehrens@google.com> Co-authored-by: Carlos Israel Ortiz García <goodwine@google.com> Co-Authored-By: Natalie Weizenbaum <nweiz@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/dart-sass#849
[skip dart-sass]