Merge pull request #713 from mgreter/todo-test/error-with-unicode

Add spec test for error reporting with unicode involved
sass · Jan 19, 2016 · daff4d6 · daff4d6
2 parents bf60606 + d01d003
commit daff4d6
Show file tree

Hide file tree

Showing 17 changed files with 22 additions and 2 deletions.
diff --git a/lib/sass_spec/test_case.rb b/lib/sass_spec/test_case.rb
@@ -99,7 +99,7 @@ def output
   end
 
   def expected
-    output = File.read(@expected_path, :binmode => true)
+    output = File.read(@expected_path, :binmode => true, :encoding => "ASCII-8BIT")
     # we seem to get CP850 otherwise
     # this provokes equal test to fail
     output.force_encoding('ASCII-8BIT')
@@ -111,7 +111,7 @@ def expected
   end
 
   def expected_error
-    @expected_error = _clean_error(File.read(@error_path, :binmode => true))
+    @expected_error = _clean_error(File.read(@error_path, :binmode => true, :encoding => "ASCII-8BIT"))
   end
 
   def expected_status

diff --git a/spec/libsass-todo-tests/errors/unicode/invalid/after/error b/spec/libsass-todo-tests/errors/unicode/invalid/after/error
@@ -0,0 +1,3 @@
+Error: Invalid UTF-8 character "\xF6"
+        on line 1 of /sass/spec/errors/unicode/invalid/after/input.scss
+  Use --trace for backtrace.
diff --git a/spec/libsass-todo-tests/errors/unicode/invalid/after/expected_output.css b/spec/libsass-todo-tests/errors/unicode/invalid/after/expected_output.css
diff --git a/spec/libsass-todo-tests/errors/unicode/invalid/after/input.scss b/spec/libsass-todo-tests/errors/unicode/invalid/after/input.scss
@@ -0,0 +1 @@
+foo{;��������
diff --git a/spec/libsass-todo-tests/errors/unicode/invalid/after/status b/spec/libsass-todo-tests/errors/unicode/invalid/after/status
@@ -0,0 +1 @@
+65
diff --git a/spec/libsass-todo-tests/errors/unicode/invalid/before/error b/spec/libsass-todo-tests/errors/unicode/invalid/before/error
@@ -0,0 +1,3 @@
+Error: Invalid UTF-8 character "\xF6"
+        on line 1 of /sass/spec/errors/unicode/invalid/before/input.scss
+  Use --trace for backtrace.
diff --git a/spec/libsass-todo-tests/errors/unicode/invalid/before/expected_output.css b/spec/libsass-todo-tests/errors/unicode/invalid/before/expected_output.css
diff --git a/spec/libsass-todo-tests/errors/unicode/invalid/before/input.scss b/spec/libsass-todo-tests/errors/unicode/invalid/before/input.scss
@@ -0,0 +1 @@
+��������{a:c
diff --git a/spec/libsass-todo-tests/errors/unicode/invalid/before/status b/spec/libsass-todo-tests/errors/unicode/invalid/before/status
@@ -0,0 +1 @@
+65
diff --git a/spec/libsass-todo-tests/errors/unicode/report/after/error b/spec/libsass-todo-tests/errors/unicode/report/after/error
@@ -0,0 +1,3 @@
+Error: Invalid CSS after "foo{;öüäöüäöü": expected "{", was ""
+        on line 1 of /sass/spec/errors/unicode/report/after/input.scss
+  Use --trace for backtrace.
diff --git a/spec/libsass-todo-tests/errors/unicode/report/after/expected_output.css b/spec/libsass-todo-tests/errors/unicode/report/after/expected_output.css
diff --git a/spec/libsass-todo-tests/errors/unicode/report/after/input.scss b/spec/libsass-todo-tests/errors/unicode/report/after/input.scss
@@ -0,0 +1 @@
+foo{;öüäöüäöü
diff --git a/spec/libsass-todo-tests/errors/unicode/report/after/status b/spec/libsass-todo-tests/errors/unicode/report/after/status
@@ -0,0 +1 @@
+65
diff --git a/spec/libsass-todo-tests/errors/unicode/report/before/error b/spec/libsass-todo-tests/errors/unicode/report/before/error
@@ -0,0 +1,3 @@
+Error: Invalid CSS after "öüäöüäöü{a:c": expected "{", was ""
+        on line 1 of /sass/spec/errors/unicode/report/before/input.scss
+  Use --trace for backtrace.
diff --git a/spec/libsass-todo-tests/errors/unicode/report/before/expected_output.css b/spec/libsass-todo-tests/errors/unicode/report/before/expected_output.css
diff --git a/spec/libsass-todo-tests/errors/unicode/report/before/input.scss b/spec/libsass-todo-tests/errors/unicode/report/before/input.scss
@@ -0,0 +1 @@
+öüäöüäöü{a:c
diff --git a/spec/libsass-todo-tests/errors/unicode/report/before/status b/spec/libsass-todo-tests/errors/unicode/report/before/status
@@ -0,0 +1 @@
+65