Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node 21 support #3408

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Node 21 support #3408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc245b1
feat(package): node 21 support
dvdknaap Mar 20, 2024
07b7e5f
chore(ci): remove node 16 support
dvdknaap Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/alpine.yml
View file
Open in desktop
Expand Up @@ -15,10 +15,10 @@ jobs:
fail-fast: false
matrix:
node:
- 16
- 18
- 19
- 20
- 21

steps:
- name: Install Alpine build tools
Expand Down
9 changes: 4 additions & 5 deletions .github/workflows/linux.yml
View file
Open in desktop
Expand Up @@ -14,10 +14,6 @@ jobs:
fail-fast: false
matrix:
include:
- node: 16
gcc: "gcc-8"
gpp: "g++-8"
os: ubuntu-20.04
- node: 18
gcc: "gcc-8"
gpp: "g++-8"
Expand All @@ -30,7 +26,10 @@ jobs:
gcc: "gcc-10"
gpp: "g++-10"
os: ubuntu-22.04

- node: 21
gcc: "gcc-10"
gpp: "g++-10"
os: ubuntu-22.04

steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/macos.yml
View file
Open in desktop
Expand Up @@ -14,10 +14,10 @@ jobs:
fail-fast: false
matrix:
node:
- 16
- 18
- 19
- 20
- 21

steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/windows.yml
View file
Open in desktop
Expand Up @@ -14,10 +14,10 @@ jobs:
fail-fast: false
matrix:
node:
- 16
- 18
- 19
- 20
- 21

architecture:
- x64
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Expand Up @@ -17,6 +17,7 @@ Below is a quick guide for minimum and maximum supported versions of node-sass:

NodeJS | Supported node-sass version | Node Module
--------|-----------------------------|------------
Node 21 | 9.0+ | 119
Node 20 | 9.0+ | 115
Node 19 | 8.0+ | 111
Node 18 | 8.0+ | 108
Expand Down
6 changes: 3 additions & 3 deletions appveyor.yml
View file
Open in desktop
Expand Up @@ -33,9 +33,6 @@
environment:
SKIP_SASS_BINARY_DOWNLOAD_FOR_CI: true
matrix:
- nodejs_version: 16
GYP_MSVS_VERSION: 2019
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
- nodejs_version: 18
GYP_MSVS_VERSION: 2019
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
Expand All @@ -45,6 +42,9 @@
- nodejs_version: 20
GYP_MSVS_VERSION: 2019
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
- nodejs_version: 21
GYP_MSVS_VERSION: 2019
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019


install:
Expand Down
3 changes: 2 additions & 1 deletion lib/extensions.js
View file
Open in desktop
Expand Up @@ -85,6 +85,7 @@ function getHumanNodeVersion(abi) {
case 108: return 'Node.js 18.x';
case 111: return 'Node.js 19.x';
case 115: return 'Node.js 20.x';
case 120: return 'Node.js 21.x';
default: return false;
}
}
Expand All @@ -111,7 +112,7 @@ function getHumanEnvironment(env) {
}

if (!platform) {
platform = 'Unsupported platform (' + parts[0] + ')';
platform = 'Unsupported platform (' + parts[0] + '/' + process.versions.modules + ')';
}

if (!arch) {
Expand Down