Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Node 18 and 19 support and drop Node 17 #3257

Merged
merged 3 commits into from
Nov 9, 2022
Merged

Conversation

nschonni
Copy link
Contributor

Fixes #3251
Still needs Node Docker image release before this will pass

@nschonni
Copy link
Contributor Author

@xzyfer should I just drop the Docker/Alpine part for now so this can just land? It's been flaky for awhile on the previous releases anyway.
I picked v8 instead of 7.1, but that can be updated too

@xzyfer
Copy link
Contributor

xzyfer commented May 4, 2022

My hero

@nschonni
Copy link
Contributor Author

Looks like x86 should be good in 18.3.0 nodejs/build#2956 and Node 17 is EOL tomorrow.
@xzyfer would it make sense to push out a release after those 2 things?

@rasmustoender
Copy link

rasmustoender commented Jun 3, 2022

@xzyfer would be awesome to have this reviewed soon! :)

@nschonni nschonni force-pushed the node-18 branch 2 times, most recently from e1bf447 to d02b7b4 Compare June 4, 2022 01:09
@nschonni nschonni changed the title feat: Node 18 support feat: Node 18 support and drop Node 17 Jun 4, 2022
@nschonni nschonni linked an issue Jun 4, 2022 that may be closed by this pull request
@John-H-Smith
Copy link

News about that?

@gengjiawen
Copy link

@nschonni Can you merge this ? thx

@gengjiawen
Copy link

We may need to bump nan version

npm ERR! /Users/daniel/Library/Caches/node-gyp/18.4.0/include/node/v8config.h:460:35: note: expanded from macro 'V8_DEPRECATED'
npm ERR! # define V8_DEPRECATED(message) [[deprecated(message)]]
npm ERR!                                   ^
npm ERR! In file included from ../src/binding.cpp:1:
npm ERR! In file included from ../../nan/nan.h:2818:
npm ERR! ../../nan/nan_typedarray_contents.h:34:43: error: no member named 'GetContents' in 'v8::ArrayBuffer'
npm ERR!       data   = static_cast<char*>(buffer->GetContents().Data()) + byte_offset;

@reynldi
Copy link

reynldi commented Jul 24, 2022

Any update ? For how long we need to wait this PR ?

@eduardocque
Copy link

+1

@alexgwolff
Copy link

Hi, any update?

@eduardocque
Copy link

Hi, any updates about this @nschonni

Regards

@chrishough
Copy link

+1

@hanorine
Copy link

Would love to see this merged in too. Hoping this package is still maintained. +1

@eduardocque

This comment was marked as off-topic.

@nholden-re
Copy link

Now that Node 18 is the active LTS, can we please get this PR some traction?

@Nic128 Nic128 mentioned this pull request Nov 7, 2022
7 tasks
@wratho
Copy link

wratho commented Nov 7, 2022

Really would like to hear an update on the state of Node 18. currently blocked from progressing without it.

@Shane32
Copy link

Shane32 commented Nov 8, 2022

If not a final release, could a beta release be published with node 18 support?

Copy link
Contributor

@xzyfer xzyfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Master should be fixed now and nan and node-gyp have been updated to support node 19.

@reynldi
Copy link

reynldi commented Nov 8, 2022

Master should be fixed now and nan and node-gyp have been updated to support node 19.

Awesome !

@xzyfer xzyfer changed the title feat: Node 18 support and drop Node 17 feat: Node 18 and 19 support and drop Node 17 Nov 9, 2022
@xzyfer xzyfer merged commit 98e75b3 into sass:master Nov 9, 2022
@doncem
Copy link

doncem commented Nov 9, 2022

well that took just a brief period of time 😏

@xzyfer
Copy link
Contributor

xzyfer commented Nov 9, 2022

That's on me. Apologies to everyone waiting on this release, and to @nschonni for disappearing for a little while.

Part of our release process for when adding new Node versions I still run manually offline and I was occupied with other priorities. We're looking to better automate the process for future releases.

@nschonni nschonni deleted the node-18 branch November 9, 2022 15:18
kodiakhq bot pushed a commit to X-oss-byte/Canary-nextjs that referenced this pull request Oct 8, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [node-sass](https://togithub.com/sass/node-sass) | [`^6.0.0 \|\| ^7.0.0` -> `^6.0.0 \|\| ^7.0.0 \|\| ^9.0.0`](https://renovatebot.com/diffs/npm/node-sass/7.0.3/9.0.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/node-sass/9.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/node-sass/9.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/node-sass/7.0.3/9.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/node-sass/7.0.3/9.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>sass/node-sass (node-sass)</summary>

### [`v9.0.0`](https://togithub.com/sass/node-sass/releases/tag/v9.0.0)

[Compare Source](https://togithub.com/sass/node-sass/compare/v8.0.0...v9.0.0)

#### What's Changed

-   Node 20 support by [@&#8203;nschonni](https://togithub.com/nschonni) in [sass/node-sass#3355

##### Breaking changes

-   Drop support for Node 14 ([@&#8203;nschonni](https://togithub.com/nschonni))

#### Supported Environments

| OS | Architecture | Node |
| --- | --- | --- |
| Windows | x86 & x64 | 16, 18, 19, 20 |
| OSX | x64 | 16, 18, 19, 20 |
| Linux\* | x64 | 16, 18, 19, 20 |
| Alpine Linux | x64 | 16, 18, 19, 20 |

\*Linux support refers to major distributions like Ubuntu, and Debian

### [`v8.0.0`](https://togithub.com/sass/node-sass/releases/tag/v8.0.0)

[Compare Source](https://togithub.com/sass/node-sass/compare/v7.0.3...v8.0.0)

#### What's Changed

-   Fix binaries being partially downloaded by [@&#8203;xzyfer](https://togithub.com/xzyfer) in [sass/node-sass#3313
-   Bump node-gyp and nan for node 19 support by [@&#8203;xzyfer](https://togithub.com/xzyfer) in [sass/node-sass#3314
-   feat: Node 18 and 19 support and drop Node 17 by [@&#8203;nschonni](https://togithub.com/nschonni) in [sass/node-sass#3257

##### Breaking changes

-   Drop support for Node 12 ([@&#8203;nschonni](https://togithub.com/nschonni))
-   Drop support for Node 17 ([@&#8203;nschonni](https://togithub.com/nschonni))
-   Set `rejectUnauthorized` to `true` by default ([@&#8203;scott-ut](https://togithub.com/scott-ut), [#&#8203;3149](https://togithub.com/sass/node-sass/issues/3149))

##### Features

-   Add support for Node 18 ([@&#8203;nschonni](https://togithub.com/nschonni))
-   Add support for Node 19 ([@&#8203;nschonni](https://togithub.com/nschonni))
-   Replace `request` with `make-fetch-happen` ([@&#8203;CamilleDrapier](https://togithub.com/CamilleDrapier)  [@&#8203;xzyfer](https://togithub.com/xzyfer), [#&#8203;3193](https://togithub.com/sass/node-sass/issues/3193), [#&#8203;3313](https://togithub.com/sass/node-sass/issues/3313))

##### Dependencies

-   Bump true-case-path@2.2.1
-   Bump node-gyp [@&#8203;9](https://togithub.com/9).0.0
-   Bump nan@^2.17.0
-   Bump sass-graph@^4.0.1

##### Misc

-   Bump various GitHub Actions dependencies ([@&#8203;nschonni](https://togithub.com/nschonni))

#### Supported Environments

| OS | Architecture | Node |
| --- | --- | --- |
| Windows | x86 & x64 | 14, 16, 18, 19 |
| OSX | x64 | 14, 16, 18, 19 |
| Linux\* | x64 | 14, 16, 18, 19 |
| Alpine Linux | x64 | 14, 16, 18, 19 |
| FreeBSD | i386 amd64 | 12, 14 |

\*Linux support refers to major distributions like Ubuntu, and Debian

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Canary-nextjs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for Node 17 Node 18 support (module 108)