Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Node 17 support #3195

Merged
merged 2 commits into from Oct 22, 2021
Merged

feat: Add Node 17 support #3195

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fa6ffa
feat: Add Node 17 support
nschonni Oct 22, 2021
3b35f52
fix: Version range for 17
nschonni Oct 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/alpine.yml
View file
Open in desktop
Expand Up @@ -19,6 +19,7 @@ jobs:
- 14
- 15
- 16
- 17

include:
- node: 12
Expand All @@ -29,6 +30,8 @@ jobs:
python: python3
- node: 16
python: python3
- node: 17
python: python3

steps:
- name: Install Alpine build tools
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/linux.yml
View file
Open in desktop
Expand Up @@ -18,6 +18,7 @@ jobs:
- 14
- 15
- 16
- 17

include:
- node: 12
Expand All @@ -36,6 +37,10 @@ jobs:
gcc: "gcc-8"
gpp: "g++-8"
os: ubuntu-18.04
- node: 17
gcc: "gcc-8"
gpp: "g++-8"
os: ubuntu-18.04


steps:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/macos.yml
View file
Open in desktop
Expand Up @@ -18,6 +18,7 @@ jobs:
- 14
- 15
- 16
- 17

steps:
- uses: actions/checkout@v2
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/windows.yml
View file
Open in desktop
Expand Up @@ -18,6 +18,7 @@ jobs:
- 14
- 15
- 16
- 17

architecture:
- x64
Expand All @@ -32,6 +33,8 @@ jobs:
os: windows-2019
- node: 16
os: windows-2019
- node: 17
os: windows-2019

steps:
- uses: actions/checkout@v2
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Expand Up @@ -17,6 +17,7 @@ Below is a quick guide for minimum and maximum supported versions of node-sass:

NodeJS | Supported node-sass version | Node Module
--------|-----------------------------|------------
Node 17 | 6.0+ | 102
nschonni marked this conversation as resolved.
Show resolved Hide resolved
Node 16 | 6.0+ | 93
Node 15 | 5.0+ | 88
Node 14 | 4.14+ | 83
Expand Down
3 changes: 3 additions & 0 deletions appveyor.yml
View file
Open in desktop
Expand Up @@ -45,6 +45,9 @@
- nodejs_version: 16
GYP_MSVS_VERSION: 2019
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
- nodejs_version: 17
GYP_MSVS_VERSION: 2019
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019

install:
# https://www.appveyor.com/docs/lang/nodejs-iojs/#installing-any-version-of-nodejs-or-iojs
Expand Down
1 change: 1 addition & 0 deletions lib/extensions.js
View file
Open in desktop
Expand Up @@ -81,6 +81,7 @@ function getHumanNodeVersion(abi) {
case 83: return 'Node.js 14.x';
case 88: return 'Node.js 15.x';
case 93: return 'Node.js 16.x';
case 102: return 'Node.js 17.x';
default: return false;
}
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
@@ -1,6 +1,6 @@
{
"name": "node-sass",
"version": "6.0.1",
"version": "7.0.0",
"libsass": "3.5.5",
"description": "Wrapper around libsass",
"license": "MIT",
Expand Down