Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node 13 support #2766

Merged
merged 1 commit into from Oct 23, 2019
Merged

Node 13 support #2766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 16 additions & 3 deletions .travis.yml
View file
Open in desktop
Expand Up @@ -16,6 +16,12 @@ jobs:
- stage: platform-test
node_js: "node"
os: osx
- stage: platform-test
node_js: "12"
os: linux
- stage: platform-test
node_js: "12"
os: osx
- stage: platform-test
node_js: "11"
os: linux
Expand Down Expand Up @@ -74,12 +80,19 @@ addons:
- g++-4.7
- gcc-4.9
- g++-4.9
- gcc-6
- g++-6

before_install:
- echo $TRAVIS_NODE_VERSION
- npm config set python `which python`
- if [ $TRAVIS_OS_NAME == "linux" ]; then
if [[ $(node -v) =~ v[1-9][0-9] ]]; then
if [[ $(node -v) =~ v13 ]]; then
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to BUILDING.md we should be using gcc 6 also for node 12... II think we should change this

export CC="gcc-6";
export CXX="g++-6";
export LINK="gcc-6";
export LINKXX="g++-6";
elif [[ $(node -v) =~ v[1-9][0-9] ]]; then
export CC="gcc-4.9";
export CXX="g++-4.9";
export LINK="gcc-4.9";
Expand All @@ -94,8 +107,8 @@ before_install:
- nvm --version
- node --version
- npm --version
- gcc --version
- g++ --version
- ${CC:-gcc} --version
- ${CXX:-g++} --version

install:
- npm install
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Expand Up @@ -4,6 +4,7 @@

NodeJS | Minimum node-sass version | Node Module
--------|--------------------------|------------
Node 13 | (not yet release) | 79
Node 12 | 4.12+ | 72
Node 11 | 4.10+ | 67
Node 10 | 4.9+ | 64
Expand Down
6 changes: 6 additions & 0 deletions appveyor.yml
View file
Open in desktop
Expand Up @@ -76,6 +76,9 @@
- nodejs_version: 12
GYP_MSVS_VERSION: 2017
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
- nodejs_version: 13
GYP_MSVS_VERSION: 2017
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
saper marked this conversation as resolved.
Show resolved Hide resolved

install:
# https://www.appveyor.com/docs/lang/nodejs-iojs/#installing-any-version-of-nodejs-or-iojs
Expand Down Expand Up @@ -173,6 +176,9 @@
- nodejs_version: 12
GYP_MSVS_VERSION: 2017
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
- nodejs_version: 13
GYP_MSVS_VERSION: 2017
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017

install:
# https://www.appveyor.com/docs/lang/nodejs-iojs/#installing-any-version-of-nodejs-or-iojs
Expand Down
1 change: 1 addition & 0 deletions lib/extensions.js
View file
Open in desktop
Expand Up @@ -78,6 +78,7 @@ function getHumanNodeVersion(abi) {
case 64: return 'Node.js 10.x';
case 67: return 'Node.js 11.x';
case 72: return 'Node.js 12.x';
case 79: return 'Node.js 13.x';
default: return false;
}
}
Expand Down