Correct usage on win32-on-arm64 platforms to look for x64 native variant #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntkme
approved these changes
Dec 30, 2023
nex3
approved these changes
Jan 2, 2024
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Jan 2, 2024
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Jan 2, 2024
jgerigmeyer
added a commit
to oddbird/embedded-host-node
that referenced
this pull request
Jan 5, 2024
jgerigmeyer
added a commit
to oddbird/dart-sass
that referenced
this pull request
Jan 8, 2024
* main: Update the pubspec and changelog for sass/embedded-host-node#266 (sass#2158) Add wait time before update website (sass#2153) Make meta.apply() an AsyncBuiltInCallable (sass#2152) Upload releases for musl-libc and android (sass#2149) Escape unprintable 0x7F (delete control character) (sass#2144) Bump dartdoc from 7.0.2 to 8.0.2 (sass#2146)
jgerigmeyer
added a commit
to oddbird/embedded-host-node
that referenced
this pull request
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#265 added support to install the x64 version when on arm64 Windows which is working fine, however there is a typo when determining the compiler path, so you get
Embedded Dart Sass couldn't find the embedded compiler executable. Please make sure the optional dependency sass-embedded-win32-x86 is installed in node_modulesValidated that things work fine with this change on arm64 Windows 11.