Make fetch happen #135
Merged
Make fetch happen #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jathak
reviewed
Apr 25, 2022
tool/utils.ts
Outdated
| @@ -2,9 +2,9 @@ | |||
| // MIT-style license that can be found in the LICENSE file or at | |||
| // https://opensource.org/licenses/MIT. | |||
|
|
|||
| const fetch = require('make-fetch-happen').defaults(); | |||
There was a problem hiding this comment.
Please use an import statement here and then assign fetch below the imports.
e.g. something like:
import {defaults as initMakeFetchHappen} 'make-fetch-happen';
// other imports
const fetch = initMakeFetchHappen();
nex3
approved these changes
Jun 13, 2022
nex3
added a commit
that referenced
this pull request
Nov 2, 2022
This reverts commit 11ecf3c. Works around DefinitelyTyped/DefinitelyTyped#59314. Now that we aren't downloading anything on end users' systems, we don't have a strong need to respect npm's proxy options.
nex3
added a commit
that referenced
this pull request
Nov 2, 2022
This reverts commit 11ecf3c. Works around DefinitelyTyped/DefinitelyTyped#59314. Now that we aren't downloading anything on end users' systems, we don't have a strong need to respect npm's proxy options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #117. I also ran into some race conditions occasionally when running
npm run init, and it looks like there were somefs.rename()calls whose promises weren't being awaited, so I addedawaits for those. I checked that in as a separate commit in case you'd prefer I split this into two PRs.