Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #417 preserve location of trailing loud comments #849

Merged
merged 6 commits into from Jun 3, 2022

Commits on May 31, 2022

  1. Fix sass#417 preserve location of trailing loud comments.

    parent 1a5102b
    author Nick Behrens <nbehrens@google.com> 1571200514 -0700
    committer Carlos Israel Ortiz García <goodwine@google.com> 1654024100 -0700
    
    Delete now unused _indent helper method in serialize.dart.
    
    Update lib/src/visitor/serialize.dart to stop using old-style int-based for loop.
    
    Co-Authored-By: Natalie Weizenbaum <nweiz@google.com>
    
    Address PR feedback.
    
    Revert parser changes.  Instead look at node span line numbers to determine whether a loud comment is trailing.
    
    Add some more test cases.
    
    Remove TODO in _isTrailingComment helper and add a better comment in there.
    
    Revert one unintentional chunk of edits to lib/src/parse/sass.dart from commit d937f87.
    
    Address some review feedback
    
    Update lib/src/visitor/serialize.dart to use var instead of CssNode as for loop variable.
    
    Co-Authored-By: Natalie Weizenbaum <nweiz@google.com>
    
    Addressing review feedback
    
    Remove some now irrelevant comments after last commit.
    
    Add some comments on some code I'd like some feedback on in the PR.
    
    Fix typo in recently added comment.
    
    Remove dupe impl of beforeChildren from CssStylesheet and some other minor cleanup.
    
    Rewrite _visitChildren to be simpler.
    
    Remove duplicate math import.
    
    Restore for loop in visitChildren to how it used to be.
    
    Comment cleanup.
    
    Don't add a trailing newline after an only-child trailing comment
    
    Minor style tweaks
    
    Short-circuit _isTrailingComment in compressed mode
    
    Update isTrailingComment to handle case where parent node contains left braces that don't open a child block.
    
    Address PR feedback, fixing indexing issue in isTrailingComment.
    
    Fix isTrailingComment to handle mixins that include loud comments.
    nickbehrens authored and Goodwine committed May 31, 2022
    Copy the full SHA
    76822b1 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. rebase squashed commits on top of main and fix style/lint issues - on…

    …e test is now failing - not done yet
    Goodwine committed Jun 1, 2022
    Copy the full SHA
    3696db4 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    d28c71a View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    25c71c2 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2022

  1. extend FileSpan to check if it [contains] another FileSpan - then use…

    … it to validate whether a comment is trailing
    Goodwine committed Jun 2, 2022
    Copy the full SHA
    5e9f642 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2022

  1. Copy the full SHA
    f81b662 View commit details
    Browse the repository at this point in the history