Merge the Dart Sass embedded compiler repo into the Dart Sass repo #1955
Conversation
This implements the packet scheme that the embedded protocol uses when communicating over stdin and stdout.
Enable Travis
Currently this doesn't actually invoke the compiler, it just always
returns the expanded output for "a {b: c}".
Add a very basic protocol dispatcher and a few tests
Add cli_pkg
This now supports real CompileRequest and CompileResponses, although it's missing features like importers, custom functions, and source maps.
This doesn't yet support first-class function values.
* Remove support for InboundMessage.FunctionCallRequest Context: sass/embedded-protocol#28 * Remove support for CanonicalizeResponse.file Context: sass/embedded-protocol#25 * Stub CompileRequest.Importer.fileImporterId support
Release a beta version
Make better use of cli_pkg
The previous token didn't seem to be recognized. See https://travis-ci.com/github/sass/dart-sass-embedded/jobs/364028782. It's unclear why it didn'twork, but I'm hoping regenerating fixes it.
I realized the problem: this repo uses travis-ci.com, not travis-ci.org, but the Travis CLI defaults to encrypting using .com credentials. This time I regenerated the token using --pro, which should work.
nex3
force-pushed
the
embedded
branch
9 times, most recently
from
3b8f0a2
to
7cd3949
Compare
nex3
force-pushed
the
embedded
branch
3 times, most recently
from
ac56a86
to
00fcf59
Compare
| @@ -103,6 +152,72 @@ jobs: | |||
| run: npm run js-api-spec -- --sassSassRepo ../language --sassPackage ../build/npm | |||
| working-directory: sass-spec | |||
|
|
|||
| # The versions should be kept up-to-date with the latest LTS Node releases. | |||
| # They next need to be rotated October 2021. See | |||
There was a problem hiding this comment.
Should we rotate these now, or save that for a separate PR?
pubspec.lock
Outdated
There was a problem hiding this comment.
Is there a reason why we're now checking this in?
There was a problem hiding this comment.
Oops, got caught in the merge.
| run: | | ||
| echo "sass=${GITHUB_REF##*/}" | tee --append $GITHUB_OUTPUT | ||
| echo "sass_api=$(curl --fail --silent --show-error --location https://raw.githubusercontent.com/sass/dart-sass/${GITHUB_REF##*/}/pkg/sass_api/pubspec.yaml | yq .version)" | tee --append $GITHUB_OUTPUT | ||
| run: echo "::set-output name=version::${GITHUB_REF##*/}" |
There was a problem hiding this comment.
| run: echo "::set-output name=version::${GITHUB_REF##*/}" | |
| run: echo "version=${GITHUB_REF##*/}" | tee --append $GITHUB_OUTPUT |
::set-output is deprecated:
There was a problem hiding this comment.
Looks like we may have a few of these. Maybe we should do this separately in a different PR.
There was a problem hiding this comment.
Yeah, I'd prefer to save this for a separate PR.
|
@nex3 Are we going to release 1.63.0 as is or are we waiting for some other changes to land? I think we should cut a release now as we already archived dart-sass-embedded repo. |
|
We're going to release it as soon as we implement the other embedded protocol changes. I want to make sure all the breaking changes are rolled into a single release. |
See #1889
See sass/embedded-host-node#218