Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make `cloneCss() clone modules that transitively contain CSS #1824

Merged
merged 2 commits into from Nov 3, 2022
Merged

Make `cloneCss() clone modules that transitively contain CSS #1824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b73bff0
Make `cloneCss() clone modules that transitively contain CSS
nex3 Nov 2, 2022
2049092
Resynchronize
nex3 Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -51,6 +51,10 @@
* Properly mark the warning for passing numbers with units to `random()` as a
deprecation warning.

* Fix a bug where `@extend` could behave unpredicatably when used along with
`meta.load-css()` and shared modules that contained no CSS themselves but
loaded CSS from other modules.

### Dart API

* Emit a deprecation warning when passing a `sassIndex` with units to
Expand Down
2 changes: 1 addition & 1 deletion lib/src/async_environment.dart
View file
Open in desktop
Expand Up @@ -1014,7 +1014,7 @@ class _EnvironmentModule implements Module {
}

Module cloneCss() {
if (css.children.isEmpty) return this;
if (!transitivelyContainsCss) return this;

var newCssAndExtensionStore = cloneCssStylesheet(css, extensionStore);
return _EnvironmentModule._(
Expand Down
4 changes: 2 additions & 2 deletions lib/src/environment.dart
View file
Open in desktop
Expand Up @@ -5,7 +5,7 @@
// DO NOT EDIT. This file was generated from async_environment.dart.
// See tool/grind/synchronize.dart for details.
//
// Checksum: 88f81b417129a74e4eb776d518c8e019dbf2ec36
// Checksum: 38c688423116df1e489aa6eafc16de1bf9bc2bf5
//
// ignore_for_file: unused_import

Expand Down Expand Up @@ -1022,7 +1022,7 @@ class _EnvironmentModule implements Module<Callable> {
}

Module<Callable> cloneCss() {
if (css.children.isEmpty) return this;
if (!transitivelyContainsCss) return this;

var newCssAndExtensionStore = cloneCssStylesheet(css, extensionStore);
return _EnvironmentModule._(
Expand Down