Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate passing non-deg units to hwb()'s $hue argument #1747

Merged
merged 2 commits into from Jul 19, 2022
Merged

Deprecate passing non-deg units to hwb()'s $hue argument #1747

merged 2 commits into from Jul 19, 2022

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Jul 19, 2022 •
edited

This was overlooked in #1175, because the spec said that hwb()
should already be throwing an error if non-deg units were passed.
However, Dart Sass didn't implement the spec correctly and these units
were in fact not being checked at all.

See #1174

See sass/sass-spec#1806

@nex3
Deprecate passing non-deg units to hwb()'s $hue argument
a2feb9b 
This was overlooked in #1175, because the spec said that `hwb()`
should already be throwing an error if non-`deg` units were passed.
However, Dart Sass didn't implement the spec correctly and these units
were in fact not being checked at all.

See #1174
@nex3 nex3 requested a review from Goodwine July 19, 2022 00:18
@nex3 nex3 merged commit 1bd7744 into main Jul 19, 2022
@nex3 nex3 deleted the hwb-hue-unit branch July 19, 2022 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goodwine Goodwine Goodwine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nex3 @Goodwine