Add support for var() with an empty fallback argument
#1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
Goodwine
approved these changes
Jun 16, 2022
stof
reviewed
Jun 22, 2022
| @@ -1688,7 +1702,7 @@ abstract class StylesheetParser extends Parser { | |||
| /// still be a valid expression. When it returns `true`, this returns the | |||
| /// expression. | |||
| @protected | |||
There was a problem hiding this comment.
shouldn't @protected is removed here ? This method is now private
| @@ -2141,7 +2155,7 @@ abstract class StylesheetParser extends Parser { | |||
| /// | |||
| /// If [singleEquals] is true, this will allow the Microsoft-style `=` | |||
| /// operator at the top level. | |||
| Expression _expressionUntilComma({bool singleEquals = false}) => expression( | |||
| Expression expressionUntilComma({bool singleEquals = false}) => _expression( | |||
There was a problem hiding this comment.
shouldn't @protected be added on this method now ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes sass/sass#3245
See sass/sass-spec#1794