Add support for arbitrary modifiers after @import #1695
Conversation
nex3
force-pushed
the
import-modifiers
branch
2 times, most recently
from
6cc90d9
to
3bd4b0f
Compare
| @@ -21,5 +21,8 @@ class SupportsAnything implements SupportsCondition { | |||
|
|
|||
| SupportsAnything(this.contents, this.span); | |||
|
|
|||
| Interpolation toInterpolation() => | |||
| Interpolation.concat(['(', contents, ')'], span); | |||
There was a problem hiding this comment.
is it actually equivalent in case a CalculationExpression is present in it ? We have a special handling for calculations in supports conditions, that would be lost here.
There was a problem hiding this comment.
Ah, good catch. Instead of converting these to interpolation, I've added an expression-level AST node just for this.
| whitespace(); | ||
| } else { | ||
| whitespace(); | ||
| if (scanner.scanChar($comma)) { |
There was a problem hiding this comment.
This support for comma looks incompatible with using the comma as separator between multiple ImportArgument.
There was a problem hiding this comment.
This actually exists to match the previous behavior: because MediaQueryList can contain commas at nearly any point, you could already write @import "..." foo, bar, baz. This just makes it more explicit.
See sass/sass#3285
See sass/sass#3290
See sass/sass-spec#1787