Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for layer condition in CSS imports #1675

Closed
wants to merge 1 commit into from
Closed

Add support for layer condition in CSS imports #1675

wants to merge 1 commit into from

Conversation

stof
Copy link
Contributor

@stof stof commented Apr 16, 2022

@stof
Copy link
Contributor Author

stof commented Apr 16, 2022

If #1671 is merged first, changelogs will need to be adapted.

@stof
Copy link
Contributor Author

stof commented Apr 16, 2022

The failing test is because the testsuite does not accept 1.0.0-beta.42-dev as version in the sass_api package, expecting 1.0.0-dev instead. It looks like it does not like when the dev version says that we will still have a beta release coming.

stof
stof commented Apr 16, 2022
View reviewed changes
lib/src/parse/stylesheet.dart
///
/// Returns `null` if neither type of query can be found.
Tuple2<SupportsCondition?, Interpolation?>? tryImportQueries() {
Tuple3<SupportsCondition?, Interpolation?, Interpolation?>?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here I added the layer as third item in the tuple, to reduce the diff in places using this function. But I'm wondering whether the layer should come first instead, to be in the same order than in CSS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nex3 any preference about the order here ?

@stof
Copy link
Contributor Author

stof commented May 18, 2022

I'm closing this PR as this implementation does not match the new version of the spec, which expects a more generic parsing.

@stof stof closed this May 18, 2022
@stof stof deleted the css_layer_import branch May 18, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for cascade layers @import urll()
1 participant
@stof