Ensure onStdinClose only completes for non-tty streams #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial stdin commit 144cd35 inverted the TTY conditional b/w the io/node and io/vm implementations of onStdinClose. The node implementation incorrectly checked for the presence of TTY to complete the stream, while the vm implementation correctly checked for its absence. The commit that landed upstream c7ab426 normalized the incorrect behaviour, which means that sass was still not closing when stdin was closed, unless stdin was a TTY. Unfortunately that created a "worst of both worlds" situation because programs that start sass and then close unexpectedly will still leave zombie sass processes running in the background, and wrapper scripts designed to mitigate this exact problem will stop working because moving the process to the background now incorrectly causes the job to stop. This change ensures we only complete the CancelableOperation onStdinClose for non-tty standard input streams.
|
Can you add a changelog entry as well? |
|
Thanks! Are you able to figure out why the Windows tests are failing? It seems unlikely to be a flake. |
|
@nex3 I can test Windows in a VM which is not ideal but it works :) I agree there's an issue and I will try to figure it out– right now running |
|
@nex3 Yes I think that's likely the best course. Other responsibilities have unfortunately taken precedence for the moment, but I would very much like to get back to this as time permits :) |
nex3
added a commit
that referenced
this pull request
May 20, 2022
nex3
requested changes
May 23, 2022
nex3
force-pushed
the
main
branch
2 times, most recently
from
9cff4ca
to
6c59213
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, thank you so much for all the work to get #1411 merged! I realized only too late that there was a small typo in my initial version that has led to a bit of a gnarly bug. 😳
The initial stdin commit 144cd35 inverted the TTY conditional
b/w the
io/nodeandio/vmimplementations ofonStdinClose.The node implementation incorrectly checked for the presence
of TTY to complete the stream, while the vm implementation
correctly checked for its absence. The commit that landed
upstream c7ab426 normalized the incorrect behaviour, which
means that sass was still not closing when stdin was closed,
unless stdin was a TTY.
Unfortunately that created a "worst of both worlds" situation
because programs that start sass and then close unexpectedly
will still leave zombie sass processes running in the
background, and wrapper scripts designed to mitigate this
exact problem will stop working because moving the process to
the background now incorrectly causes the job to stop.
This change ensures we only complete the CancelableOperation
onStdinClose for non-tty standard input streams.