Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.45.0 #1569

Merged
merged 2 commits into from Dec 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 3 additions & 7 deletions CHANGELOG.md
@@ -1,10 +1,4 @@
## 1.45.0-rc.2

### JS API

* Ship TypeScript type declarations with the package.

## 1.45.0-rc.1
## 1.45.0

### JS API

Expand Down Expand Up @@ -41,6 +35,8 @@ For full documentation of this API, please see [the Sass website][js-api].

[js-api]: https://sass-lang.com/documentation/js-api

This release also adds TypeScript type definitions.

## 1.44.0

* Suggest `calc()` as an alternative in `/`-as-division deprecation messages.
Expand Down
1 change: 0 additions & 1 deletion analysis/lib/analysis_options.yaml
Expand Up @@ -6,7 +6,6 @@ analyzer:
strict-inference: true
strict-raw-types: true
errors:
missing_js_lib_annotation: ignore
deprecated_member_use_from_same_package: ignore

# These are necessary for matching the JS API.
Expand Down
2 changes: 0 additions & 2 deletions lib/src/async_environment.dart
Expand Up @@ -2,8 +2,6 @@
// MIT-style license that can be found in the LICENSE file or at
// https://opensource.org/licenses/MIT.

import 'dart:collection';

import 'package:collection/collection.dart';
import 'package:path/path.dart' as p;
import 'package:source_span/source_span.dart';
Expand Down
4 changes: 1 addition & 3 deletions lib/src/environment.dart
Expand Up @@ -5,12 +5,10 @@
// DO NOT EDIT. This file was generated from async_environment.dart.
// See tool/grind/synchronize.dart for details.
//
// Checksum: 6e5ee671e0a6e5b1d6ac87beb6aeee1e4b155d74
// Checksum: 6b97030ff074d0b39e027ea97ba5893d242b9d3d
//
// ignore_for_file: unused_import

import 'dart:collection';

import 'package:collection/collection.dart';
import 'package:path/path.dart' as p;
import 'package:source_span/source_span.dart';
Expand Down
2 changes: 0 additions & 2 deletions lib/src/importer/node_to_dart/file.dart
Expand Up @@ -8,8 +8,6 @@ import '../../importer.dart';
import '../../node/importer.dart';
import '../../node/url.dart';
import '../../node/utils.dart';
import '../filesystem.dart';
import '../result.dart';
import '../utils.dart';

/// A filesystem importer to use for most implementation details of
Expand Down
1 change: 0 additions & 1 deletion lib/src/importer/node_to_dart/sync.dart
Expand Up @@ -9,7 +9,6 @@ import '../../node/importer.dart';
import '../../node/url.dart';
import '../../node/utils.dart';
import '../../util/nullable.dart';
import '../result.dart';

/// A wrapper for a synchronous JS API importer that exposes it as a Dart
/// [Importer].
Expand Down
1 change: 0 additions & 1 deletion lib/src/node/compile.dart
Expand Up @@ -18,7 +18,6 @@ import '../importer/node_to_dart/async_file.dart';
import '../importer/node_to_dart/file.dart';
import '../importer/node_to_dart/sync.dart';
import '../io.dart';
import '../logger.dart';
import '../logger/node_to_dart.dart';
import '../parse/scss.dart';
import '../util/nullable.dart';
Expand Down
4 changes: 4 additions & 0 deletions lib/src/node/legacy/value.dart
Expand Up @@ -27,6 +27,10 @@ export 'value/string.dart';
Value unwrapValue(Object? object) {
if (object != null) {
if (object is Value) return object;

// TODO(nweiz): Remove this ignore and add an explicit type argument once we
// support only Dart SDKs >= 2.15.
// ignore: inference_failure_on_function_invocation
var value = getProperty(object, 'dartValue');
if (value != null && value is Value) return value;
if (isJSError(object)) throw object;
Expand Down
1 change: 0 additions & 1 deletion lib/src/node/reflection.dart
Expand Up @@ -2,7 +2,6 @@
// MIT-style license that can be found in the LICENSE file or at
// https://opensource.org/licenses/MIT.

import 'dart:js';
import 'dart:js_util';

import 'package:js/js.dart';
Expand Down
1 change: 0 additions & 1 deletion lib/src/node/utils.dart
Expand Up @@ -2,7 +2,6 @@
// MIT-style license that can be found in the LICENSE file or at
// https://opensource.org/licenses/MIT.

import 'dart:js';
import 'dart:js_util';
import 'dart:typed_data';

Expand Down
1 change: 0 additions & 1 deletion lib/src/value/number/unitless.dart
Expand Up @@ -7,7 +7,6 @@ import 'package:tuple/tuple.dart';

import '../../util/number.dart';
import '../../value.dart';
import '../number.dart';

/// A specialized subclass of [SassNumber] for numbers that have no units.
///
Expand Down
4 changes: 4 additions & 0 deletions pkg/sass_api/CHANGELOG.md
@@ -1,3 +1,7 @@
## 1.0.0-beta.23

* No user-visible changes.

## 1.0.0-beta.22

* No user-visible changes.
Expand Down
4 changes: 2 additions & 2 deletions pkg/sass_api/pubspec.yaml
Expand Up @@ -2,15 +2,15 @@ name: sass_api
# Note: Every time we add a new Sass AST node, we need to bump the *major*
# version because it's a breaking change for anyone who's implementing the
# visitor interface(s).
version: 1.0.0-beta.22
version: 1.0.0-beta.23
description: Additional APIs for Dart Sass.
homepage: https://github.com/sass/dart-sass

environment:
sdk: '>=2.12.0 <3.0.0'

dependencies:
sass: 1.45.0-rc.2
sass: 1.45.0

dependency_overrides:
sass: {path: ../..}
2 changes: 1 addition & 1 deletion pubspec.yaml
@@ -1,5 +1,5 @@
name: sass
version: 1.45.0-rc.2
version: 1.45.0
description: A Sass implementation in Dart.
homepage: https://github.com/sass/dart-sass

Expand Down
1 change: 0 additions & 1 deletion test/dart_api/importer_test.dart
Expand Up @@ -9,7 +9,6 @@ import 'dart:convert';
import 'package:test/test.dart';

import 'package:sass/sass.dart';
import 'package:sass/src/exception.dart';

import 'from_import_importer.dart';
import 'test_importer.dart';
Expand Down
4 changes: 4 additions & 0 deletions test/legacy_node_api/function_test.dart
Expand Up @@ -2,6 +2,10 @@
// MIT-style license that can be found in the LICENSE file or at
// https://opensource.org/licenses/MIT.

// TODO(nweiz): Remove this ignore and add explicit type arguments once we
// support only Dart SDKs >= 2.15.
// ignore_for_file: inference_failure_on_function_invocation

@TestOn('node')
@Tags(['node'])

Expand Down
1 change: 0 additions & 1 deletion test/legacy_node_api/importer_test.dart
Expand Up @@ -8,7 +8,6 @@
import 'dart:async';

import 'package:js/js.dart';
import 'package:node_interop/js.dart';
import 'package:node_interop/node.dart';
import 'package:path/path.dart' as p;
import 'package:test/test.dart';
Expand Down
6 changes: 5 additions & 1 deletion test/legacy_node_api/value/boolean_test.dart
Expand Up @@ -43,7 +43,11 @@ void main() {

test("the constructor throws", () {
expect(
() => callConstructor(sass.types.Boolean, [true]), throwsA(anything));
// TODO(nweiz): Remove this ignore and add an explicit type argument
// once we support only Dart SDKs >= 2.15.
// ignore: inference_failure_on_function_invocation
() => callConstructor(sass.types.Boolean, [true]),
throwsA(anything));
});

group("the convenience accessor", () {
Expand Down
4 changes: 4 additions & 0 deletions test/legacy_node_api/value/color_test.dart
Expand Up @@ -2,6 +2,10 @@
// MIT-style license that can be found in the LICENSE file or at
// https://opensource.org/licenses/MIT.

// TODO(nweiz): Remove this ignore and add explicit type arguments once we
// support only Dart SDKs >= 2.15.
// ignore_for_file: inference_failure_on_function_invocation

@TestOn('node')
@Tags(['node'])

Expand Down
4 changes: 4 additions & 0 deletions test/legacy_node_api/value/list_test.dart
Expand Up @@ -2,6 +2,10 @@
// MIT-style license that can be found in the LICENSE file or at
// https://opensource.org/licenses/MIT.

// TODO(nweiz): Remove this ignore and add explicit type arguments once we
// support only Dart SDKs >= 2.15.
// ignore_for_file: inference_failure_on_function_invocation

@TestOn('node')
@Tags(['node'])

Expand Down
4 changes: 4 additions & 0 deletions test/legacy_node_api/value/map_test.dart
Expand Up @@ -2,6 +2,10 @@
// MIT-style license that can be found in the LICENSE file or at
// https://opensource.org/licenses/MIT.

// TODO(nweiz): Remove this ignore and add explicit type arguments once we
// support only Dart SDKs >= 2.15.
// ignore_for_file: inference_failure_on_function_invocation

@TestOn('node')
@Tags(['node'])

Expand Down
3 changes: 3 additions & 0 deletions test/legacy_node_api/value/null_test.dart
Expand Up @@ -29,6 +29,9 @@ void main() {
});

test("the constructor throws", () {
// TODO(nweiz): Remove this ignore and add an explicit type argument once we
// support only Dart SDKs >= 2.15.
// ignore: inference_failure_on_function_invocation
expect(() => callConstructor(sass.types.Null, []), throwsA(anything));
});

Expand Down
4 changes: 4 additions & 0 deletions test/legacy_node_api/value/number_test.dart
Expand Up @@ -2,6 +2,10 @@
// MIT-style license that can be found in the LICENSE file or at
// https://opensource.org/licenses/MIT.

// TODO(nweiz): Remove this ignore and add explicit type arguments once we
// support only Dart SDKs >= 2.15.
// ignore_for_file: inference_failure_on_function_invocation

@TestOn('node')
@Tags(['node'])

Expand Down
4 changes: 4 additions & 0 deletions test/legacy_node_api/value/string_test.dart
Expand Up @@ -2,6 +2,10 @@
// MIT-style license that can be found in the LICENSE file or at
// https://opensource.org/licenses/MIT.

// TODO(nweiz): Remove this ignore and add explicit type arguments once we
// support only Dart SDKs >= 2.15.
// ignore_for_file: inference_failure_on_function_invocation

@TestOn('node')
@Tags(['node'])

Expand Down