Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose CompileResult publicly, along with methods that return it #1398

Merged
merged 8 commits into from Jul 23, 2021
Merged

Expose CompileResult publicly, along with methods that return it #1398

merged 8 commits into from Jul 23, 2021

Commits on Jul 14, 2021

  1. Exclude build/ from static analysis

    @nex3
    nex3 committed Jul 14, 2021
    Copy the full SHA
    acdea51 View commit details
    Browse the repository at this point in the history

  2. Remove CompileResult.sourceFiles 

    This was never used.
    @nex3
    nex3 committed Jul 14, 2021
    Copy the full SHA
    0e42a09 View commit details
    Browse the repository at this point in the history

  3. Change CompileResult.includedFiles to CompileResult.includedUrls 

    Rather than constructing this explicitly to match Node Sass's API, we
construct it with canonical URLs and convert it into the format
expected by the Node Sass API (a mix of paths and URLs) in the
compatibility layer.
    @nex3
    nex3 committed Jul 14, 2021
    Copy the full SHA
    43b69e6 View commit details
    Browse the repository at this point in the history

  4. Expose CompileResult publicly, along with methods that return it 

    This also exposes CompileResult.includedUrls.

Closes #1355
Partially addresses sass/embedded-protocol#62
    @nex3
    nex3 committed Jul 14, 2021
    Copy the full SHA
    558ca0a View commit details
    Browse the repository at this point in the history

  5. Rename includedUrls to loadedUrls 

    This is more explicit, and matches the name in the embedded protocol.
    @nex3
    nex3 committed Jul 14, 2021
    Copy the full SHA
    1565b9c View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2021

  1. Merge remote-tracking branch 'origin/main' into compile-to-result

    @nex3
    nex3 committed Jul 23, 2021
    Copy the full SHA
    cbd1f6e View commit details
    Browse the repository at this point in the history

  2. Code review changes

    @nex3
    nex3 committed Jul 23, 2021
    Copy the full SHA
    5d65c11 View commit details
    Browse the repository at this point in the history

  3. Resynchronize

    @nex3
    nex3 committed Jul 23, 2021
    Copy the full SHA
    10ac094 View commit details
    Browse the repository at this point in the history